Reduce noisy WARN logs to DEBUG level#1273
Open
milanmajchrak wants to merge 1 commit intocustomer/TULfrom
Open
Reduce noisy WARN logs to DEBUG level#1273milanmajchrak wants to merge 1 commit intocustomer/TULfrom
milanmajchrak wants to merge 1 commit intocustomer/TULfrom
Conversation
Changed two frequently occurring WARN log messages to DEBUG level: - Context.java: 'Initializing a context while an active transaction exists' - ClarinItemServiceImpl.java: 'Cannot update item dates metadata because the approximate date is empty'
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce log noise by downgrading a frequently occurring WARN in Context initialization (“Initializing a context while an active transaction exists”) to DEBUG in the customer/TUL branch (cherry-pick of #1263, limited to Context.java).
Changes:
- Adjusts the log level for the “active transaction exists” message in
Context.init()from WARN to DEBUG. - (Intended) keep behavior the same while reducing noisy production logs.
Comments suppressed due to low confidence (1)
dspace-api/src/main/java/org/dspace/core/Context.java:193
init()no longer initializescurrentUserandcurrentLocale(previously set to anonymous +I18nUtil.getDefaultLocale()), sogetCurrentLocale()can return null. This breaks existing expectations (e.g.,ContextTest#testGetCurrentLocale) and can cause NPEs in callers that immediately usecontext.getCurrentLocale()for email templates/formatting. Restore initialization of these fields during context initialization.
extraLogInfo = "";
ignoreAuth = false;
specialGroups = new HashSet<>();
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+179
to
+188
| <<<<<<< HEAD | ||
| ======= | ||
| } else { | ||
| if (isTransactionAlive()) { | ||
| log.debug("Initializing a context while an active transaction exists. Context with hash: {}.", | ||
| } else { | ||
| if (isTransactionAlive()) { | ||
| log.debug("Initializing a context while an active transaction exists. Context with hash: {}.", | ||
| getHash()); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #1263 into customer/TUL.
Problem description
Changed one frequently occurring WARN log message to DEBUG level:
Note: ClarinItemServiceImpl.java has a minimal version in this branch without the relevant method, so only Context.java change is applied.
Original PR: #1263