Reduce noisy WARN logs to DEBUG level#1272
Open
milanmajchrak wants to merge 1 commit intocustomer/mendelufrom
Open
Reduce noisy WARN logs to DEBUG level#1272milanmajchrak wants to merge 1 commit intocustomer/mendelufrom
milanmajchrak wants to merge 1 commit intocustomer/mendelufrom
Conversation
Changed two frequently occurring WARN log messages to DEBUG level: - Context.java: 'Initializing a context while an active transaction exists' - ClarinItemServiceImpl.java: 'Cannot update item dates metadata because the approximate date is empty'
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce log noise by lowering the severity of a frequently occurring log message during Context initialization in the DSpace core API.
Changes:
- Adds a DEBUG log when initializing a
Contextwhile an active transaction exists (intended to replace/avoid a WARN).
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+186
to
+187
| log.debug("Initializing a context while an active transaction exists. Context with hash: {}.", | ||
| getHash()); |
Comment on lines
+184
to
+188
| } else { | ||
| if (isTransactionAlive()) { | ||
| log.debug("Initializing a context while an active transaction exists. Context with hash: {}.", | ||
| getHash()); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #1263 into customer/mendelu.
Problem description
Changed one frequently occurring WARN log message to DEBUG level:
Note: ClarinItemServiceImpl.java does not exist in this branch, so only Context.java change is applied.
Original PR: #1263