ZCU-DATA/Reduce noisy WARN logs to DEBUG level#1270
Closed
milanmajchrak wants to merge 1 commit intocustomer/zcu-datafrom
Closed
ZCU-DATA/Reduce noisy WARN logs to DEBUG level#1270milanmajchrak wants to merge 1 commit intocustomer/zcu-datafrom
milanmajchrak wants to merge 1 commit intocustomer/zcu-datafrom
Conversation
Changed two frequently occurring WARN log messages to DEBUG level: - Context.java: 'Initializing a context while an active transaction exists' - ClarinItemServiceImpl.java: 'Cannot update item dates metadata because the approximate date is empty'
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce log noise by downgrading two frequently occurring WARN log messages to DEBUG, improving operational signal-to-noise in customer deployments.
Changes:
- Adds a DEBUG log in
Context.init()when initializing while a transaction is already active. - Adds a DEBUG log in
ClarinItemServiceImpl.deriveDateIssuedFromApproximateDate()when the approximate date is missing/blank.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dspace-api/src/main/java/org/dspace/core/Context.java | Adds a DEBUG log for “context initialized with active transaction” scenario (but currently introduces a compile issue). |
| dspace-api/src/main/java/org/dspace/content/clarin/ClarinItemServiceImpl.java | Adds a DEBUG log when approximate date metadata is empty (but WARN still remains in the caller, causing duplicate logging). |
You can also share your feedback on Copilot code review. Take the survey.
dspace-api/src/main/java/org/dspace/content/clarin/ClarinItemServiceImpl.java
Show resolved
Hide resolved
milanmajchrak
changed the title
Collaborator
Author
|
We do not need to log that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #1263 into customer/zcu-data.
Problem description
Changed two frequently occurring WARN log messages to DEBUG level:
Original PR: #1263