VSB-TUO/ORCID authority search fix

[milanmajchrak]

Problem description

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

• Added to testing scenarios

Copilot review

• Requested review from Copilot

[Copilot]

Pull request overview

Updates Hibernate session cache eviction behavior to avoid triggering lazy-loading of Bundle bitstreams when a Bundle may be detached, preventing LazyInitializationException during uncacheEntity().

Changes:

• Adjusts HibernateDBConnection.uncacheEntity() logic for Bundle to avoid calling Bundle.getBitstreams() in scenarios where the entity is detached.
• Adds detailed inline rationale explaining why Bundle.getBitstreams() is unsafe to call as a lazy-init guard.

Comments suppressed due to low confidence (2)

dspace-api/src/main/java/org/dspace/core/HibernateDBConnection.java:314

• getSession().contains(bundle) only checks whether the Bundle entity is managed; it does not indicate whether the bitstreams collection is initialized. As a result, this branch will still force initialization via bundle.getBitstreams() whenever the bundle is in-session (potentially triggering extra DB reads), and it will skip uncaching bitstreams for detached bundles even when the bitstreams collection is already initialized. With Hibernate 5.6 available in this repo, prefer Hibernate.isPropertyInitialized(bundle, "bitstreams") (or equivalent) to guard iteration without triggering lazy-loading, and keep behavior aligned with the surrounding Hibernate.isInitialized(...) patterns (e.g. for Item.getBundles()).

                if (getSession().contains(bundle)) {
                    for (Bitstream bitstream : Utils.emptyIfNull(bundle.getBitstreams())) {
                        uncacheEntity(bitstream);
                    }
                }

dspace-api/src/main/java/org/dspace/core/HibernateDBConnection.java:314

• This change is addressing a LazyInitialization edge case in uncacheEntity() for Bundles, but there is no test covering the Bundle/bitstreams eviction path. Please add/extend unit/integration tests (e.g. in HibernateDBConnectionTest) to verify uncacheEntity(bundle) does not throw when the Bundle is detached and bitstreams is uninitialized, and that it does not unexpectedly initialize the collection when it shouldn't.

                if (getSession().contains(bundle)) {
                    for (Bitstream bitstream : Utils.emptyIfNull(bundle.getBitstreams())) {
                        uncacheEntity(bitstream);
                    }
                }