Skip to content

0.37.1: fixes from the review of 0.37.0 - #19

Merged
echarles merged 2 commits into
mainfrom
fix/0.37.1
Nov 17, 2026
Merged

echarles merged 2 commits into
mainfrom
fix/0.37.1

Conversation

@echarles

Copy link
Copy Markdown
Member

Patch for the Copilot review of #18, in both SDKs:

  • Bound refresh tokens and Bearer-only MCP servers: the refresh proves with the refresh token's DPoP key whenever the issuer lists ES256 (spec 4.4); the reference companies issue Bearer for a server whose metadata lists no ES256 (spec 4.5). Fixture dpop.mcp-proof-from-the-servers-metadata and case dpop.mcp-server-decides-the-proof updated.
  • open_link/openLink reads the link's own record and never takes the callback state; complete consumes it once and drops the link.
  • effectiveContext (TS) defines own properties: a __proto__ field stays a field (Python's dict was unaffected).
  • An empty SSE event: name is the default message event.
  • dpop.pushed-authorization-request requires an explicit OAuth refusal.
  • Python 3.10 byte order: already fixed in 0.37.0: Poppy 1.0 as published #18 (af0b11b); the 3.10 job runs the PS384 tests.

Examples keeps AGENT_RUNTIMES_REF: feat/scenes until agent-runtimes 1.6.83 is on PyPI.

Local: Python 1603 passed; TypeScript 1073 passed, 1 skipped; cross-language 19 passed.

A bound refresh token keeps its sign-in at a Bearer-only MCP server (the refresh proves with
the refresh token's key whenever the issuer lists ES256; the company gives such a server
Bearer tokens); open_link reads the link's own record and leaves the callback state to
complete; effectiveContext defines own properties (a __proto__ field stays a field); an empty
SSE event name is a message; the PAR conformance check requires an explicit OAuth refusal.
Tests in both SDKs.
Copilot AI balanced review requested due to automatic review settings November 17, 2026 11:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Link handling can resurrect unusable authorization links during concurrent callback completion and permanently reject unexpired links created by version 0.37.0 after an upgrade.

2 open issues
What changed in this PR

This patch release addresses feedback from 0.37.0 across the Python and TypeScript SDKs and reference companies, focusing on authentication and protocol edge cases.

Changes:

  • Aligns refresh-token proofs with issuer capabilities and MCP token types with server metadata.
  • Separates sign-in link records from callback state, preserves TypeScript __proto__ context fields, and handles empty SSE event names.
  • Adds regression coverage, tightens conformance checks, and updates release metadata to 0.37.1.
File Description
src/​reactor.ts Updates the core plugin version.
src/​models.ts Preserves context fields as own properties.
src/​conversations.ts Treats empty SSE event names as messages.
src/​company/​service.ts Issues Bearer tokens for Bearer-only MCP resources.
src/​company/​index.ts Updates the company plugin version.
src/​auth.ts Separates link records from callback state and adds cleanup.
src/​accounts.ts Preserves issuer-required proofs during MCP refreshes.
src/​__tests__/​support/​conformance.mjs Tightens authorization refusal and MCP token checks.
src/​__tests__/​published-10.test.mjs Adds TypeScript regression coverage.
protocol/​requirements.yaml Links the MCP issuance helper to requirements.
protocol/​fixtures/​conformance/​dpop.json Updates proof expectations and case descriptions.
personal_agent_protocol/​reactor.py Updates the core plugin version.
personal_agent_protocol/​conversations.py Treats empty SSE event names as messages.
personal_agent_protocol/​conformance.py Updates authorization refusal and MCP token checks.
personal_agent_protocol/​company/​service.py Issues Bearer tokens for Bearer-only MCP resources.
personal_agent_protocol/​company/​__init__.py Updates the company plugin version.
personal_agent_protocol/​auth.py Separates link records from callback state and adds cleanup.
personal_agent_protocol/​accounts.py Preserves issuer-required proofs during MCP refreshes.
personal_agent_protocol/​__version__.py Sets the Python release version.
personal_agent_protocol/​__tests__/​test_published_10.py Adds Python regression coverage.
package.json Sets the npm release version.
docs/​docs/​releases/​compatibility.mdx Documents the patch’s compatibility changes.
docs/​docs/​protocol/​coverage/​operational-guidance.mdx Adds the MCP issuance helper to coverage references.
docs/​docs/​protocol/​conformance-report.mdx Updates the reported SDK version.
CHANGELOG.md Summarizes 0.37.1 fixes and clarifies the prior Python fix.

Review effort: Balanced

Comment thread src/auth.ts
Comment on lines +594 to 595
const pending = await store.take(linkKey);
if (!isPendingDirectSignIn(pending) || clock.now().getTime() > pending.expiresAt.getTime()) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #20 (0.37.2), both SDKs: a link record that is a string beginning direct: (what 0.37.0 kept) is followed to the pending sign-in with a non-consuming read, so an unexpired 0.37.0 link opens after an upgrade and its sign-in still completes. Mixed-version replicas are documented in the changelog (a 0.37.0 replica cannot read newer links: roll every replica serving link pages first, or route link pages to upgraded ones). Test: a link begun by 0.37.0 opens after an upgrade without consuming its state (Python and TypeScript).

Comment thread src/auth.ts
}
await store.put(reference as string, pending, { expiresAt: pending.expiresAt });
await store.put(linkKey, reference, { expiresAt: pending.expiresAt });
await store.put(linkKey, pending, { expiresAt: pending.expiresAt });

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #20 (0.37.2), both SDKs: open_link / openLink no longer take and put back. They read with get, a new optional method of AuthorizationStateStore (a SHOULD: read without consuming); take is left to the callback alone, so a completed sign-in's link can't be restored. The SDKs' in-memory stores have get; a store without it is still read by take then put, which the docs say to fix. Regression test: an opening paused while the callback completes never restores the link (a store paused between reading and returning, complete run in between).

@echarles
echarles merged commit 8b19846 into main Nov 17, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants