Repository navigation
0.36.1: persisted Sessions without a version restore at 0.4 (TypeScript) - #15
Merged
Merged
Conversation
…peScript, as in Python PapSession.fromJson() passed no protocol version for a Session persisted before 0.36, so the new 1.0 default applied under the same sid and changed Poppy-Version mid-Session. It now restores such a Session at 0.4 (PROTOCOL_PROFILE), as PapSession.from_json() does; a Session persisted with its version keeps it, and a new one defaults to 1.0. Tests in both SDKs.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the session-restoration compatibility change.
No open issues 🎉
What changed in this PR
This patch aligns TypeScript session restoration with Python after the 1.0 default introduced in #14. Persisted sessions without a protocol version restore as 0.4, while explicit versions are preserved and new sessions still default to 1.0.
Changes:
- Fix TypeScript’s fallback for persisted sessions missing
protocol_version. - Add regression tests in both SDKs for restored and newly created sessions.
- Bump package and plugin versions to 0.36.1 and update release documentation.
| File | Description |
|---|---|
src/sessions.ts |
Restore versionless persisted sessions as 0.4. |
src/reactor.ts |
Bump the TypeScript core plugin version. |
src/company/index.ts |
Bump the TypeScript company plugin version. |
src/__tests__/sessions.test.mjs |
Test restored versions and the new-session default. |
personal_agent_protocol/reactor.py |
Bump the Python core plugin version. |
personal_agent_protocol/company/__init__.py |
Bump the Python company plugin version. |
personal_agent_protocol/__version__.py |
Set the Python SDK version to 0.36.1. |
personal_agent_protocol/__tests__/test_sessions.py |
Add matching session-version regression tests. |
package.json |
Set the npm package version to 0.36.1. |
docs/docs/releases/compatibility.mdx |
Document the patch’s compatibility behavior. |
docs/docs/protocol/conformance-report.mdx |
Update the report’s SDK version label. |
CHANGELOG.md |
Describe the restoration fix in the 0.36.1 entry. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14 (review comment on src/sessions.ts):
PapSession.fromJson()now restores a Session persisted withoutprotocol_versionat 0.4, as Python'sPapSession.from_json()already does, instead of the new 1.0 default under the same sid. A persisted version is kept; new Sessions default to 1.0. Tests in both SDKs; version 0.36.1, changelog and compatibility row.