HTML-escape table cell text to prevent < being parsed as tags#997
Open
Br1an67 wants to merge 1 commit intodatalab-to:masterfrom
Open
HTML-escape table cell text to prevent < being parsed as tags#997Br1an67 wants to merge 1 commit intodatalab-to:masterfrom
Br1an67 wants to merge 1 commit intodatalab-to:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
<characters in table cells being parsed as HTML tags by escaping cell text content before embedding it in the HTML representation.In
TableCell.assemble_html(), cell text lines were joined directly into HTML without escaping. When a cell contained<(e.g.,<LOQ), it was interpreted as a broken HTML tag by the downstream HTML parser (BeautifulSoup/markdownify), corrupting the table output.Closes #881
Changes
html.escape()to each text line inTableCell.assemble_html()before joining them into the HTML<td>/<th>element<,>, and&in cell text are properly escaped as<,>, and&Example
Before:
<td><LOQ</td>→ parsed as broken HTML tagAfter:
<td><LOQ</td>→ correctly preserved as literal text