Added DatalabAPIError handling for create_item#86
Merged
ml-evs merged 3 commits intodatalab-org:mainfrom Mar 19, 2026
Merged
Conversation
When creating an item while trying to attach it to a collection, which does not exist, the DatalabAPIError is not handled correctly. Adding this specific error to the except options solved the issue and correctly creates a collection to attach the item to.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 43.14% 42.88% -0.26%
==========================================
Files 5 5
Lines 496 499 +3
==========================================
Hits 214 214
- Misses 282 285 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
pre-commit.ci run |
Member
|
pre-commit.ci autofix |
ml-evs
approved these changes
Mar 19, 2026
Member
ml-evs
left a comment
There was a problem hiding this comment.
Thanks for this @wuppersaver!
I'll make a minor tweak that makes the linters pass and then merge this.
ml-evs
reviewed
Mar 19, 2026
ml-evs
reviewed
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating an item while trying to attach it to a collection, which does not exist, the DatalabAPIError is not handled correctly. Adding this specific error to the except options solved the issue and correctly creates a collection to attach the item to.
Traceback: