fix(ingest): skip empty columns for CLL#17615
Merged
Merged
Conversation
github-actions
Bot
added
the
ingestion
Contributor
|
Linear: ING-2776 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
kyungsoo-datahub
approved these changes
May 28, 2026
Contributor
|
Thank you @kevinkarchacryl for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sqlglot SQL parser upgrade from v29 to v30 (shipped in 1.5.0.19) changed how certain SQL patterns are analyzed during CLL extraction, causing some upstream column names to be empty strings. These empty strings were being passed directly to make_schema_field_urn(), producing invalid URNs of the form urn:li:schemaField:(urn:li:dataset:(...),) that GMS rejects, causing the entire ingestion to fail. The fix adds guards in two places in dbt_common.py.