feat(i18n): extract keys from entity validations tab#17583
feat(i18n): extract keys from entity validations tab#17583v-tarasevich-blitz-brain merged 5 commits into
Conversation
6832a91 to
52abe6e
Compare
|
✅ Meticulous spotted visual differences in 2 of 1341 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~10 hours of user flows against your PR. Last updated for commit |
Bundle ReportChanges will increase total bundle size by 20.49kB (0.09%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
This would be easier to review if the base branch is temporarily set to vt--cat-2139--extract-keys-from-home-pages. |
52abe6e to
dafc8f2
Compare
dafc8f2 to
7eccd58
Compare
7eccd58 to
36d19a5
Compare
|
Linear: CAT-2194 |
| "name": "Name", | ||
| "status": "Status", | ||
| "tags": "Tags", | ||
| "type": "type" |
There was a problem hiding this comment.
Nit: questionable if lowercase labels should be here or moved to entity.validations.
This PR extracts i18n keys from
src/app/entityV2/shared/tabs/Dataset/Validations/Some functions use string building which are not translatable right now without refactoring of them.