Skip to content

feat(i18n): extract keys from entity validations tab#17583

Merged
v-tarasevich-blitz-brain merged 5 commits into
masterfrom
vt--cat-2150--extract-keys-from-dataset-validation
May 29, 2026
Merged

feat(i18n): extract keys from entity validations tab#17583
v-tarasevich-blitz-brain merged 5 commits into
masterfrom
vt--cat-2150--extract-keys-from-dataset-validation

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented May 26, 2026

This PR extracts i18n keys from src/app/entityV2/shared/tabs/Dataset/Validations/

Some functions use string building which are not translatable right now without refactoring of them.

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented May 27, 2026

✅ Meticulous spotted visual differences in 2 of 1341 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit 30a5b2b resolve comments. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Bundle Report

Changes will increase total bundle size by 20.49kB (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.26MB 20.49kB (0.09%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 7.41kB 8.79MB 0.08%
assets/en-*.js 13.08kB 69.83kB 23.05% ⚠️

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/Summary/AcrylAssertionSummaryCard.tsx → Total Size: 3.89kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/Summary/AcrylAssertionSummarySection.tsx → Total Size: 2.05kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/utils.tsx → Total Size: 13.17kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/AssertionProfile.tsx → Total Size: 1.2kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionPlatformAvatar.tsx → Total Size: 1.1kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/DataContractBadge.tsx → Total Size: 734 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/Summary/AcrylAssertionSummaryTab.tsx → Total Size: 1.81kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AcrylValidationsTab.tsx → Total Size: 4.25kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/SchemaSummaryModal.tsx → Total Size: 620 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/Tags/AcrylAssertionTagColumn.tsx → Total Size: 5.64kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AcrylAssertionsTableColumns.tsx → Total Size: 1.36kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/hooks.tsx → Total Size: 4.87kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/builder/hooks.ts → Total Size: 1.3kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/FreshnessAssertionDescription.tsx → Total Size: 1.97kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/SchemaAssertionDescription.tsx → Total Size: 832 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/acrylUtils.tsx → Total Size: 7.28kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/FieldAssertionDescription.tsx → Total Size: 1.66kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AcrylAssertionsTable.tsx → Total Size: 5.84kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/VolumeAssertionDescription.tsx → Total Size: 871 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/AcrylAssertionListTable.tsx → Total Size: 2.57kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/AcrylAssertionList.tsx → Total Size: 2.94kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/AssertionGroupHeader.tsx → Total Size: 1.54kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/AssertionListTitleContainer.tsx → Total Size: 911 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/SchemaSummary.tsx → Total Size: 1.79kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/AcrylAssertionListConstants.tsx → Total Size: 3.54kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/DatasetAssertionDescription.tsx → Total Size: 14.15kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AssertionList/AcrylAssertionListFilters.tsx → Total Size: 3.52kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/DatasetAssertionLogicModal.tsx → Total Size: 403 bytes

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title [WIP] feat(i18n): extract keys from enety validations tab [WIP] feat(i18n): extract keys from entity validations tab May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rtion/profile/summary/shared/resultMessageUtils.ts 83.33% 4 Missing ⚠️
datahub-web-react/src/i18n/i18n.ts 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@benjiaming
Copy link
Copy Markdown
Contributor

This would be easier to review if the base branch is temporarily set to vt--cat-2139--extract-keys-from-home-pages.

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--cat-2150--extract-keys-from-dataset-validation branch from 7eccd58 to 36d19a5 Compare May 28, 2026 19:16
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title [WIP] feat(i18n): extract keys from entity validations tab feat(i18n): extract keys from entity validations tab May 28, 2026
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain marked this pull request as ready for review May 28, 2026 19:16
@github-actions
Copy link
Copy Markdown
Contributor

Linear: CAT-2194

"name": "Name",
"status": "Status",
"tags": "Tags",
"type": "type"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: questionable if lowercase labels should be here or moved to entity.validations.

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain merged commit b591df2 into master May 29, 2026
46 checks passed
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain deleted the vt--cat-2150--extract-keys-from-dataset-validation branch May 29, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants