Repository navigation
fix(registry): registra i dataset mart-only nel catalogo - #513
Merged
Merged
Conversation
I compose senza clean: non entravano nella sezione datasets: i mart restavano orfani e ACB/MCP non vedevano il dataset. Ora build_clean_catalog emette una entry con metadati e mart_refs, senza columns/location; lo schema rende i due campi opzionali.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
I compose mart-only (senza
clean:) non entrano nella sezionedatasetsdel registry: i loro mart ci sono, ma restano orfani. ACB costruiscetopic_indexsolo dai dataset, quindi il compose non è visibile (find/explore) egcs_querynon riesce a risalire al repo produttore.Questa PR li registra come dataset senza
columns/location, con metadati emart_refs.Contesto collegato
Nessuna issue: bug emerso pubblicando
filiere-agroalimentari(composefiliere_valore_aggiunto). Stesso pattern per altri mart-only (energia_incroci,resource_dependency_compose, ...).Cosa cambia
Impatto su contratti pubblici
registry.json:columnselocationdiventano opzionali per i dataset mart-only (backward-compatible).dataset.yml, path output o schema parquet.Verifica
pytest -m core ruff check . mypy toolkit/pytest -m corepassa (222 passed, 1 skipped)ruff check .passamypy toolkit/passacontractVerifica manuale:
toolkit registry build(dry-run) sufiliere-agroalimentariora producedatasets 7confiliere_valore_aggiuntoe i suoimart_refs, senza errori di validazione. Provato anche suopen-conto-annuale,italia-dipendenze,energia-italia,open-ccnl,imprese-italia.Checklist PR
Note per chi revisiona
Il fix copre i mart-only veri (assenza di
clean:). Un dataset conclean.sqlma parquet locale mancante continua a produrre warning e viene saltato: è un caso diverso (output mancante), non un mart-only.