Repository navigation
refactor: dashboard usa lab-connectors nativamente - #2
Merged
Merged
Conversation
- sources.py: load_mart_table + query_clean da LC, slug resolution - app.py: apply_branding() da LC - fmt_pct default senza segno (signed=True per delta) - SQL page: render_sql_query da LC - Rimossa logica custom (load_clean, fmt_mt, fmt_it, _resolve_slug) - Rimossi load_clean() pesanti da pagine (query SQL diretta)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor dashboard per usare lab-connectors nativamente
Cosa cambia
sources.py:load_mart_table+query_cleandalab_connectors.duckdb.queries, slug resolution,fmt_num/fmt_pctdalab_connectors.formattersapp.py:apply_branding()dalab_connectors.brandingfmt_pctdefault senza segno (signed=Trueper delta) — fix in lab-connectorsrender_sql_querydalab_connectors.duckdb.sql_pageload_clean,fmt_mt,fmt_it,_resolve_slug)load_clean()pesanti da pagine (query SQL diretta)Risultati
Dependances
lab-connectors[duckdb]aggiunto adashboard/requirements.txt