Repository navigation
breaking: rimosso mcp_servers/github-discussions — migrato a dcl-mcp - #93
Merged
Merged
Conversation
…clab/dcl-mcp Il server MCP per GitHub Discussions (7 tool) violava la regola 'qui non stanno tool MCP di dominio' ed era l'eccezione dichiarata nel README: migrato in dataciviclab/dcl-mcp insieme al resto del server unico del Lab (context ACB + gcs_query). Client GraphQL e nomi tool invariati. Rimossi: mcp_servers/, tests/mcp/test_github_discussions.py (coperti da dcl-mcp/tests), exclude setuptools. README: l'eccezione diventa nota di migrazione. 430 test passano; 2 errori mypy preesistenti su main (branding, registry_page — fuori perimetro).
…p.logging (core, resta)
Member
Author
|
Nota per revisione: il primo commit ha rimosso l'intera cartella tests/mcp/; il secondo commit ripristina |
…nito qui per errore con git add -A
La coverage CI è caduta sotto soglia dopo la rimozione del server discussions: i test del server coprivano indirettamente lab_connectors mcp.core (guard/guard_timed). Aggiunti i test unitari del core infrastrutturale, che resta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Il server MCP per GitHub Discussions esce da lab-connectors: era
l'eccezione dichiarata al README ("viola la regola — server di dominio
in un repo di infrastruttura"). Migra in
dataciviclab/dcl-mcpcon nome server e nomi tool invariati (
github_*).Contesto collegato
Migrazione MCP del Lab: ACB server → dcl-mcp (acb#96).
Cosa cambia
mcp_servers/github-discussions/(client + server)tests/mcp/test_github_discussions.py(coperti da dcl-mcp/tests)mcp_serversContratti pubblici
lab_connectors.mcp(factory, guard_timed, TtlCache): invariato — lo usa dcl-mcpdcl-mcp, non più dal checkout lab-connectorsVerifica
pytestpassamcp_servers/github-discussionsnel packageChecklist PR