Repository navigation
chore: migrate packaging to setuptools, align with org standard (A3) - #94
Merged
Merged
Conversation
Per infra/lab-ops/standards/pyproject.md (which names ACB explicitly): - hatchling -> setuptools>=68; src-layout via [tool.setuptools.packages.find] where=["src"] - dist name agent-context-builder -> dataciviclab-agent-context-builder (entry points agent-context / agent-context-mcp unchanged) - license dict -> "MIT" string; drop stale 3.10/3.11 classifiers - drop requests (never imported; HTTP via lab_connectors.http) - ruff target-version py310 -> py312 (coherent with requires-python) - add [project.urls] Repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Migrazione del packaging di ACB da hatchling a setuptools e allineamento completo allo standard org
infra/lab-ops/standards/pyproject.md, che nomina esplicitamente ACB come caso da migrare ("including ACB/hatchling → migrate to setuptools").Contesto collegato
Terza e ultima PR della fase di pulizia pre-catalog (A1 #92, A2 #91+#93). Dopo il merge, si passa alla fase B (CatalogFetcher per-repo).
Cosa cambia
Impatto su artifact upstream
ACB consuma artifact da source-observatory e dataset-incubator.
Verifica
pytest tests/passa (152 passed, 86% cov)ruff check src/passamypy src/ tests/passadataciviclab-agent-context-builder)agent-context --helpfunzionauv buildproduce wheel corretto (agent_context_builder/+ dist-info)Checklist PR
Note per chi revisiona
agent-context-builder→dataciviclab-agent-context-builder(standarddataciviclab-<nome>). Gli entry pointagent-contexteagent-context-mcpnon cambiano. La CI installa via-e ".[dev]"(path), quindi non ne risente. Dopo il merge serve un reinstall nelle venv locali che usavano il vecchio nome.requestsrimosso: mai importato nel sorgente — l'HTTP passa dalab_connectors.http.HttpClient. Verificato con grep susrc/,scripts/,tests/.requires-python = ">=3.12"; lo standard non li prevede.target-versionpy310 → py312: coerente con requires-python e con il root workspace.http,mcp,registry) — la regola "transitive non si ripetono" del standard riguarda chi dipende da toolkit.[tool.ruff]/[tool.mypy]mantenuti: necessari perché la CI esegue gli tool sulla checkout del solo repo (nessun pyproject genitore); i valori sono allineati al root workspace.