Repository navigation
[AIGTWY-4877] Add MPS and MCP two-agent CUJ - #993
Conversation
d887243 to
132fea4
Compare
132fea4 to
20baee9
Compare
2539627 to
31bb970
Compare
2bacf37 to
60f93ce
Compare
1ac1c0d to
320af2d
Compare
320af2d to
1fa74e1
Compare
133d9f3 to
f187532
Compare
UG reviewThe PR changes Codex MCP credential forwarding and workspace discovery URL construction, and adds two-agent workspace CUJs with teardown cleanup. Major
Automated advisory review of |
david-siqi-liu
left a comment
There was a problem hiding this comment.
Approving. One P1 to follow up on, not blocking:
P1
- The MPS listing, MPS get, and Anthropic models calls now build URLs from
normalize_workspace_url(workspace), which only adds a scheme and strips a trailing/.ug configure --workspacestores the URL as typed, so a workspace pasted ashttps://<host>/?o=123turns the listing URL intohttps://<host>/?o=123/api/2.1/.... Before this change,https://{hostname}dropped the query. #1004 addsworkspace_origin(scheme plus netloc, keeps the recorder port), and #987 carries the same hunks verbatim. Using it here avoids three PRs editing these lines three different ways.
|
Follow-up after checking the test against the CUJ 2 plan in the UG Configure E2E doc. My approval stands, but I think these are must-fix before this counts as CUJ 2 coverage: P0 (coverage)
P1
Skills are deferred per the PR body; that's the same Files API blocker CUJ 3 and CUJ 6 hit, so I'm treating it as a shared follow-up rather than blocking this PR. |
Thanks for the review @david-siqi-liu I think initially we skipped running MCPs and skills because there was some issue with the workspace setup. I'm going to merge this PR and see what we can fix here as a followup. |
list_model_services and the coding-agent config, recommendation, and
external-price calls rebuilt the URL as https://{hostname}, so the TUI request
recorder at http://127.0.0.1:<port> was dialed at port 443. Use
normalize_workspace_url, the same pattern as inference requests, #999, and #993.
Co-authored-by: Isaac <no-reply@databricks.com>
What did you change, and why?
Added the dedicated CUJ2 journey for a real published
CodingAgentConfig: Codex usesug_e2e.providers.openaiwithgpt-5-nano, Claude usesug_e2e.providers.anthropicwithclaude-haiku-4-5-20251001, and both invokesystem.ai.sandboxthrough the real agent TUIs. The runner and managed CI lane now execute the serialized workspace-backed CUJ with service-principal auth, preserve/restore any prior config, redact credentials, and install the pinned SDK through the authenticated internal Python proxy.Skill coverage is intentionally deferred because the workspace Skill backend currently has a storage-path failure. This CUJ contains no Skill configuration, download, invocation, or assertion path.
How do you know it works?
system.ai.sandboxand the negativesystem.ai.web_searchfixture.This PR was created with GitHub MCP.