Skip to content

Support agent-specific Smart Router Orchestrator skills - #1076

Merged
JJ27 merged 3 commits into
mainfrom
JJ27/ug-agent-specific-orchestrator-skills
Oct 9, 2026
Merged

JJ27 merged 3 commits into
mainfrom
JJ27/ug-agent-specific-orchestrator-skills

Conversation

@JJ27

@JJ27 JJ27 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

What did you change, and why?

Allow Smart Router Orchestrator to ship separate Claude Code and Codex instructions. Installation writes the selected SKILL.<agent>.md as the agent's SKILL.md, and prompt/compaction hooks select the same file via an explicit agent argument. Existing skills with one shared SKILL.md continue to work.

Both new files contain the current instructions unchanged. Shared role files and resources stay in place, so later instruction changes can be stacked on this PR.

How do you know it works?

  • 168 focused component tests passed, covering installation, updates, shared skills, matching hook content, routing launches, and the integration contract.
  • Built and installed the wheel into an isolated directory, then executed the generated prompt and compaction hooks for both agents using distinct temporary instruction text. Verified matching installed content, flag-off behavior, unchanged installs, and all five Claude roles.
  • Ruff checks and formatting for src/ and tests/, and ty check src/, passed.

Live-agent integration was not run locally. The extra documented lint check on the unchanged scripts/run_integration.py reports two existing TID251 violations; the normal repository lint gate passes.

@JJ27
JJ27 marked this pull request as ready for review October 9, 2026 17:05
Copilot AI balanced review requested due to automatic review settings October 9, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@JJ27
JJ27 added this pull request to stack #1077 October 9, 2026 17:09
@JJ27
JJ27 force-pushed the JJ27/ug-agent-specific-orchestrator-skills branch from 5363284 to ae4c3d4 Compare October 9, 2026 19:12
Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@JJ27
JJ27 requested a review from lilly-luo October 9, 2026 19:18
Comment thread src/ucode/smart_routing/orchestrator.py Outdated
Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@JJ27
JJ27 added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit 59a7b84 Oct 9, 2026
96 of 100 checks passed
@JJ27
JJ27 deleted the JJ27/ug-agent-specific-orchestrator-skills branch October 9, 2026 21:05
GirishS2093 pushed a commit to GirishS2093/unity-gateway that referenced this pull request Oct 11, 2026
Builds on the agent-specific skill support merged in
[databricks#1076](databricks#1076).

## What did you change, and why?

Update the Claude and Codex Smart Router Orchestrator instructions with
separate workflows for task ownership, focused evidence gathering, and
independent parallel assignments.

- Claude keeps connected investigations in the root when delegation
would repeat the work. A delegated owner handles discovery,
implementation, checks, and an integration-ready result.
- Codex chooses the final-answer owner before delegation. For delegated
read-only investigations that the root will present, one child acquires
the complete cited evidence and the root synthesizes it. Implementation
owners retain the full edit, test, and fix loop.

Preserve the supplied workflows, role scopes, and execution safeguards.
Keep the UG name, full activation and on/off guidance, and runtime
model-evidence requirement. Adapt native Claude role names and
references to the standalone plugin's unbundled configuration helper.
Claude keeps its Sonnet role defaults. Codex requests Luna without
forcing a reasoning effort, allowing a routed model to use its supported
default. This avoids a rejected spawn when the routed model does not
support `max`. One restricted fallback attempt remains for rejected
bundled defaults; UG routing can replace the requested model. Explicit
user and policy constraints still apply.

When a harness truncates the hook output, both skills direct it to read
the full agent-specific file before proceeding.

Changes are limited to the two skill instruction files and their README.
Both skill files use version 1.2.0.

## How do you know it works?

- 33 focused tests passed across `test_skills.py` and
`test_codex_routing.py`, covering installation, agent-specific hook
content, and routing.
- Compared each file directly with its supplied source: the original
delegation rules, role scopes, coordination instructions, and
integration/verification text are preserved with the agreed UG
adaptations; UG's runtime-evidence guidance is appended. Codex's
recovery conditions and single retry are retained, replacing only the
helper-generated eligibility value with a written rule.
- YAML/entrypoint checks, the standard Ruff lint/format and type-check
gate, and diff checks passed.

The truncated-hook recovery still needs live CI verification. Live-agent
quality, cost, and latency have not been evaluated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants