Repository navigation
ci: Drive Windows integration TUIs through ConPTY - #1058
Open
max-rozen-oss-db wants to merge 22 commits into
Open
max-rozen-oss-db wants to merge 22 commits into
max-rozen-oss-db wants to merge 22 commits into
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
max-rozen-oss-db
force-pushed
the
max-rozen-oss-db/stack/windows-conpty
branch
from
October 8, 2026 21:38
333f47d to
53aaef6
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…ys on Windows Co-authored-by: Isaac <no-reply@databricks.com>
max-rozen-oss-db
marked this pull request as ready for review
October 9, 2026 01:08
…uite node ID Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…ture reads Co-authored-by: Isaac <no-reply@databricks.com>
The trust-directory dialog check was using strict regex patterns that relied on exact character matching for the selection indicator. On Windows ConPTY, the selection character may render differently, causing the dialog to not be recognized and tests to timeout waiting for the usable prompt. Simplify the dialog detection by checking for the dialog text and option text using case-insensitive substring matching instead of strict regex patterns. Co-authored-by: Isaac <no-reply@databricks.com>
…olders The regex pattern has no f-string placeholders, so it should use r"" instead of rf"". Co-authored-by: Isaac <no-reply@databricks.com>
…t placeholders" This reverts commit 44ab595.
…indows" This reverts commit 6fbc368.
Co-authored-by: Isaac <no-reply@databricks.com>
max-rozen-oss-db
enabled auto-merge
October 9, 2026 15:49
The glyph is a real › on screen; U+FFFD only appeared in CI's cp1252 log output. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
The model's command shapes kept outrunning a read-only allowlist, so approve each prompt and keep these journeys testing ug. Also retry the Smart Router controls read while ug replaces the file on Windows. Co-authored-by: Isaac <no-reply@databricks.com>
The sandbox picker's arrow-key navigation could land on Quit when keys arrived late, so seed the choice before launch instead. Codex can drop the first Enter on the trust dialog during startup, so answer it again if it stays up. Wait for approval options to render. Co-authored-by: Isaac <no-reply@databricks.com>
…env fix Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drives interactive agents through ConPTY on Windows so the integration suite's TUI modules run there instead of being filtered out.
tests/integration/utils/terminal.py: the PTY layer isPosixPty(pexpect, unchanged) orConPty(pywinpty), picked byos.name. ConPTY reads on a daemon thread, launches.cmd/.batthroughcmd.exe /c, and tears down withtaskkill /T.[windows] sandbox = "unelevated"before each Codex launch, so the TUI skips its sandbox picker.boot()matches the trust-directory dialog with either path separator and answers it again if it is still up after 10s (Codex can drop the first Enter during startup). Codex asks before every shell command there, soapprove_windows_commandapproves each prompt (Codex on Windows only; any other agent's prompt still fails). This keeps these journeys testing ug rather than the model's choice of command; the task only reads a fixture on a throwaway runner with the non-admin sandbox. Approval waits until the prompt's options render.apiKeyHelperwithsplit_command(CreateProcess rules), compare the helper without.EXE, read user settings where Linux reads/etcmanaged settings, seed the Codex sandbox in the lifecycle test's ownconfig.toml, read transcripts as UTF-8.scripts/run_integration.py: Windows live runs keep the PTY modules and installpywinpty==3.0.5;WINDOWS_UNSUPPORTED_NODESdeselects the managed-settings seeding journey (ug has no Windows managed-settings path) and, until ug's session-env fix lands, the Codex Smart Router skill toggle (Codex's Windows sandbox can't read ug's owner-only session-env dir).tests/test_e2e_cuj_helpers.py: the fakeugis a Python script with aug.cmdor/bin/shlauncher, so theTerminaltests run on Windows. Two newer tests whose fakes drive the tty withtermiosstay skipped there.Verification
tests/test_e2e_cuj_helpers.py,tests/test_integration_runner.py, andtests/test_integration_contract.pypass.;/&&chains, scripts withif/throw,[IO.File]::ReadAllText); an allowlist couldn't keep up andapproval_policy = "never"didn't stop the prompts, so the test now approves them.This pull request and its description were written by the Isaac LLM tool (Claude Code, session
053e9e2b-b4dd-41dc-9287-b081cc6ed1bc).