Skip to content

Update examples using scripts/update_from_templates.sh and add missing files#114

Merged
lennartkats-db merged 1 commit into
mainfrom
update-pipelines-2025-10
Oct 23, 2025
Merged

Update examples using scripts/update_from_templates.sh and add missing files#114
lennartkats-db merged 1 commit into
mainfrom
update-pipelines-2025-10

Conversation

@lennartkats-db

@lennartkats-db lennartkats-db commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

This updates the examples based on the templates of CLI 0.274.0.

Closes #118.

@lennartkats-db lennartkats-db enabled auto-merge (squash) October 14, 2025 18:51

@pietern pietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a lot of files, but doesn't remove any. Expected?

dependencies:
# We include every dependency defined by pyproject.toml by defining an editable environment
# that points to the folder where pyproject.toml is deployed.
- --editable ${workspace.file_path}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the most recent CLI release, you can use -e ../...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that only works with the latest CLI 🤷 Anyone with an older version gets a very confusing error. That's why the templates use this form for now...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not referred to anywhere.

Does this come from a released CLI?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that pipeline sources are all in a directory, do we still need the notebook or can it be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still the old template from main 🤷 We'll get rid of this soon!

@lennartkats-db

Copy link
Copy Markdown
Contributor Author

This adds a lot of files, but doesn't remove any. Expected?

I just double-checked it; these are indeed the files generated after deleting all files and re-generating them with CLI 0.274.0.

@lennartkats-db lennartkats-db changed the title Update examples using scripts/update_from_templates.sh Update examples using scripts/update_from_templates.sh and add missing files Oct 23, 2025
@pietern

pietern commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Thanks for checking.

@lennartkats-db lennartkats-db merged commit 36f8515 into main Oct 23, 2025
1 check passed
@lennartkats-db lennartkats-db deleted the update-pipelines-2025-10 branch October 23, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the main branch deoesn't have the resource and src code for LDP

2 participants