Skip to content

chore: upgrade databend-meta stack to land rotbl 0.2.10#19703

Merged
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer:2005-rotbl
Apr 12, 2026
Merged

chore: upgrade databend-meta stack to land rotbl 0.2.10#19703
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer:2005-rotbl

Conversation

@drmingdrmer
Copy link
Copy Markdown
Member

@drmingdrmer drmingdrmer commented Apr 11, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore: upgrade databend-meta stack to land rotbl 0.2.10

Bump databend-meta to 260312.6.0, databend-meta-client to
260205.5.0, and databend-base to 0.3.0. The three move in
lockstep because both the server and client trees consume
rotbl 0.2.10, which eliminates Mutex<File> serialization in the
block reader (pread-based ReaderAt) and switches the block cache
from a hand-rolled LRU to moka::sync::Cache with singleflight
loading — ~78-95x throughput improvement under contention.

databend-base 0.3.0 is part of the same cascade: the new
databend-meta server pins databend-base ^0.3.0 because the
histogram module was extracted into the standalone base2histogram
crate. databend-meta-client 260205.5.0 is the corresponding release
of the r-260205 client line carrying the same databend-base floor,
so the two trees coexist under a single [patch.crates-io] entry.

Drop snapshot_db_block_cache_item from RaftConfig: rotbl 0.2.10's
moka::sync::Cache cannot enforce an item count and a byte weight
independently, so byte capacity is now the single sizing knob.
--snapshot-db-block-cache-size remains and still defaults to 1 GiB.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 11, 2026
Copy link
Copy Markdown
Collaborator

@xp-trumpet xp-trumpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xp-trumpet reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on drmingdrmer).

@github-actions
Copy link
Copy Markdown
Contributor

🤖 CI Job Analysis

Workflow: 24288108940

📊 Summary

  • Total Jobs: 87
  • Failed Jobs: 1
  • Retryable: 0
  • Code Issues: 1

NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • linux / sqllogic / standalone_iceberg_tpch: Not retryable (Code/Test)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

Bump `databend-meta` to `260312.6.0`, `databend-meta-client` to
`260205.5.0`, and `databend-base` to `0.3.0`. The three move in
lockstep because both the server and client trees consume
`rotbl 0.2.10`, which eliminates `Mutex<File>` serialization in the
block reader (pread-based `ReaderAt`) and switches the block cache
from a hand-rolled LRU to `moka::sync::Cache` with singleflight
loading — ~78-95x throughput improvement under contention.

`databend-base 0.3.0` is part of the same cascade: the new
`databend-meta` server pins `databend-base ^0.3.0` because the
`histogram` module was extracted into the standalone `base2histogram`
crate. `databend-meta-client 260205.5.0` is the corresponding release
of the r-260205 client line carrying the same `databend-base` floor,
so the two trees coexist under a single `[patch.crates-io]` entry.

Drop `snapshot_db_block_cache_item` from `RaftConfig`: rotbl 0.2.10's
`moka::sync::Cache` cannot enforce an item count and a byte weight
independently, so byte capacity is now the single sizing knob.
`--snapshot-db-block-cache-size` remains and still defaults to 1 GiB.
@drmingdrmer drmingdrmer merged commit 71145e1 into databendlabs:main Apr 12, 2026
12 checks passed
@drmingdrmer drmingdrmer deleted the 2005-rotbl branch April 12, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants