Skip to content

chore(query): remove unused clickhouse handler#19697

Merged
youngsofun merged 2 commits intodatabendlabs:mainfrom
KKould:chore/remove-clickhouse-handler
Apr 13, 2026
Merged

chore(query): remove unused clickhouse handler#19697
youngsofun merged 2 commits intodatabendlabs:mainfrom
KKould:chore/remove-clickhouse-handler

Conversation

@KKould
Copy link
Copy Markdown
Member

@KKould KKould commented Apr 10, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR removes the unused ClickHouse compatibility handler from query startup, routing, session handling, and related configuration surfaces.

It also cleans up the remaining ClickHouse handler config/env/template entries in tests, deployment assets, helper scripts, and fixtures so the dead endpoint is fully removed instead of only being disabled in code.

Validation performed:

cargo fmt --all
cargo clippy -p databend-query --tests -- -D warnings
cargo clippy -p databend-binaries --bin databend-query -- -D warnings

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - This is dead code/config cleanup; I validated with fmt and clippy but did not add or run new functional test cases.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 10, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8fb95d1ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@KKould KKould force-pushed the chore/remove-clickhouse-handler branch from f8fb95d to f378969 Compare April 10, 2026 10:44
@KKould
Copy link
Copy Markdown
Member Author

KKould commented Apr 10, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@youngsofun youngsofun added this pull request to the merge queue Apr 13, 2026
Merged via the queue into databendlabs:main with commit 41466f0 Apr 13, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants