refactor(binder): make flatten_plan return explicit derived-column mappings#19696
Open
forsaken628 wants to merge 1 commit intodatabendlabs:mainfrom
Open
refactor(binder): make flatten_plan return explicit derived-column mappings#19696forsaken628 wants to merge 1 commit intodatabendlabs:mainfrom
forsaken628 wants to merge 1 commit intodatabendlabs:mainfrom
Conversation
github-actions
bot
added
the
pr-refactor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 913e9d43b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/query/sql/src/planner/optimizer/optimizers/operator/decorrelate/flatten_plan.rs
Outdated
Show resolved
Hide resolved
forsaken628
force-pushed
the
flatten_plan
branch
from
913e9d4 to
b5553e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor subquery decorrelation so flatten_plan returns (SExpr, DerivedColumnMap) instead of relying on implicit
self.derived_columns side effects
Tests
Type of change
This change is