fix(query): support broadcast join with merge-limit build#19652
Open
SkyFan2002 wants to merge 8 commits intodatabendlabs:mainfrom
Open
fix(query): support broadcast join with merge-limit build#19652SkyFan2002 wants to merge 8 commits intodatabendlabs:mainfrom
SkyFan2002 wants to merge 8 commits intodatabendlabs:mainfrom
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Add execution-layer fallback for ExchangeSource when the source fragment is not present in the local QueryCoordinator. - carry source DataExchange metadata through Fragmenter - return Option from fragment subscription lookups - build merge/broadcast/shuffle/global-shuffle sources directly from remote receivers when local fragment expansion is unavailable Validation: - cargo check -p databend-query --lib - cargo build -p databend-query --lib
Register and lazily create inbound channel sets for do_exchange receivers so remote-only exchange sources can build pipelines before network senders connect. - pre-register incoming exchange fragments during query env init - add get-or-create helpers on DataExchangeManager and QueryCoordinator - switch broadcast/global-shuffle receive paths to use get-or-create Validation: - cargo check -p databend-query --lib - db-slt --cluster --run-dir cluster --run-file subquery.test
Route inbound sender creation through the same channel-set guard used by pre-registration so mismatched exchange parallelism fails explicitly. Also add QueryCoordinator unit tests covering inbound channel set registration and mismatch detection.
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
- add a send-only broadcast sink for remote leftover fragments - allow shuffle exchanges to consume only existing remote receivers - validate with cluster cte, window_ntile, and generate_series tests
Schedule empty and singleton source fragments on the coordinator once real distributed work is absent so sink-side broadcast exchanges are not materialized for remote-only receive flows. Let pulling executors surface EOF after the execution graph has finished, and bound statistics receiver shutdown so zero-row cluster queries can fully tear down. Add cluster regressions for coordinator-only distributed paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Broadcast(Limit(Merge(Limit(Scan))))ExchangeSourcefallback and on-demand inbound channel-set creation for local broadcast/hash receiver pathsEXPLAINshape and the successful query resultTests
Type of change
This change is