Repository navigation
refactor: split teamWorkspacesRepository into domain modules - #13
Merged
Merged
Conversation
Mechanical decomposition of the 5637-line repository file with zero behavior change; the original path stays as a re-export facade so no import moves: - teamWorkspaces/contract.ts (448) — record/row types, shared constants, and the TeamWorkspacesRepository interface - teamWorkspaces/helpers.ts (1061) — pure row mappers plus billing, recovery, and workspace-access builders shared by both implementations - teamWorkspaces/mockRepository.ts (1615) — MockTeamWorkspacesRepository - teamWorkspaces/pgRepository.ts (2679) — PgTeamWorkspacesRepository Follow-up: pgRepository still exceeds the 1500-line target; shrinking it needs a delegation split of the class itself, tracked in the execution plan. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical decomposition of the 5637-line repository file — the P0 item from the execution plan's M5 follow-ups. Zero behavior change;
repositories/teamWorkspacesRepository.tsstays as a re-export facade so no import paths move.teamWorkspaces/contract.tsTeamWorkspacesRepositoryinterfaceteamWorkspaces/helpers.tsteamWorkspaces/mockRepository.tsMockTeamWorkspacesRepositoryteamWorkspaces/pgRepository.tsPgTeamWorkspacesRepositoryFollow-up:
pgRepository.tsstill exceeds the ~1500-line target; shrinking it requires a delegation split of the class itself.Test plan
pnpm --filter @sg/api test— 134 passed, unchanged🤖 Generated with Claude Code