Repository navigation
fix: make dashboard health assertions robust to streaming re-renders - #12
Merged
Merged
Conversation
The admin dashboard can briefly hold duplicate section nodes while Next.js streams a re-render, which trips Playwright strict-mode single-element locators. Anchor on the first match inside main and assert the worker and scheduler heartbeat lines by instance prefix, which is also a stronger check than the previous count of 2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Browser Release Gate intermittently fails on
admin boundary blocks anonymous access and publishes a review-ready casewith a Playwright strict-mode violation:getByText('Ingestion Worker Health')resolves to 2 elements while the dashboard streams a re-render (observed on PR #7 run 30815455030, including its retry — the label exists exactly once in the page source)..first()insidemaintoHaveCount(2)with per-instance assertions (instance worker-…andinstance scheduler-…), which is a stronger check and immune to transient duplicatesMerge before the M5 feature PRs (#7–#11) so they can pass the gate reliably.
Test plan
🤖 Generated with Claude Code