Skip to content

Fix syntax#37

Merged
csafreen merged 1 commit into
mainfrom
csafreen/fix_templates
Jun 29, 2026
Merged

Fix syntax#37
csafreen merged 1 commit into
mainfrom
csafreen/fix_templates

Conversation

@csafreen

Copy link
Copy Markdown
Contributor

Merge Checklist

Please review this list and check any items that require additions or modifications beyond your core changes. Reviewers can also use it to help confirm that nothing was missed.

Test if the flow runs successfully as an imported json file

  • Import the flow as a .json file and successfully run the flow

Test if the flow runs successfully as template

  • Switch DATAFLOW_TEMPLATE_BRANCH environment variable in docker-compose.yaml to the branch being reviewed and successfully run the flow

Inspect the nodes in the flow (either as a template or imported json file):

  • Each node has a short description that helps the user understand what the node does
  • Added documentation and type hints for embedded Python functions in flow templates (code in the Python node)
  • Result and error are removed in node data i.e. there should be no result or error visible for the nodes

[Currently not visible in UI]

  • Added a description for the flow template, including the OMOP CDM version and supported database(s)

Copilot AI review requested due to automatic review settings June 26, 2026 08:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes JSON syntax issues in the EQ-5D-5L ETL flow template so it can be imported/parsed correctly (e.g., removing invalid trailing commas / ensuring valid JSON object fields).

Changes:

  • Removed invalid trailing commas from several description / python_code fields to restore valid JSON syntax.
  • Adjusted the affected node data objects so their last properties terminate correctly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"source": "prepare_measurement_ids"
},
"description": "Describe the task of node py2table_node_0",
"description": "Describe the task of node py2table_node_0"
@csafreen csafreen merged commit a39d435 into main Jun 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants