Skip to content

fix(DMVP-10106): Cronjob updates - #222

Merged
aghamyan44 merged 5 commits into
mainfrom
DMVP-10106
Jun 11, 2026
Merged

fix(DMVP-10106): Cronjob updates#222
aghamyan44 merged 5 commits into
mainfrom
DMVP-10106

Conversation

@aghamyan44

Copy link
Copy Markdown
Contributor

No description provided.

@what-the-diff

what-the-diff Bot commented Jun 11, 2026

Copy link
Copy Markdown

PR Summary 📃✨

  • Lifting our App to Greater Heights!
    Let's celebrate 🎉, we've just upgraded our application and chart to newer versions (0.1.39). This means smoother performance for our application and a better experience for you!

  • Empowering the README!
    We've added several new fields to the README.md. These enhancements offer more flexibility and control when configuring your jobs. Remember, knowledge is power; more info means more power to you! 😄💪

  • Boosting the Templates!
    Hey, guess what? Our cronjob.yaml template just got supercharged ⚡. It now supports a bunch of new features for jobs so you can tailor things just right for your task! Isn't that fantastic?

  • Service Account Labels...sorted!
    Boom! We've just improved serviceaccount.yaml to support labels. Managing service accounts just became a whole lot easier! 🎯

  • Default Values for your Ease!
    The trip doesn't end there; we've upgraded values.yaml too 🚀. It now includes default values for many fields to make your life easier. Plus, a brand new rbac section to help create Role/ClusterRole if needed.

Keep coding, keep shining! 💎🚀

Comment thread charts/base-cronjob/values.yaml Outdated

restartPolicy: OnFailure # (optional)
startingDeadlineSeconds: 60 # (optional)
successfulJobsHistoryLimit: 1 # (optional)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • lets set default values of new added config fields with set values, for example successfulJobsHistoryLimit default is 3, jobBackoffLimit one has 6 as default. This will keep backward compatibility so that when one will update this helm to new version no issues/different behavior will be there
  • can we have description on each new added field here in form of comment in the end of line as we have for example for timeZone field?
  • please add example on root examples folder of repo on how rbac config can be activated/used

@aghamyan44
aghamyan44 merged commit 05fa78c into main Jun 11, 2026
3 checks passed
@aghamyan44
aghamyan44 deleted the DMVP-10106 branch June 11, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants