fix: don't cache recent transactions during syncing

[Syn-McJ]

Issue being fixed or feature implemented

Recent changes to transaction caching introduce a problem: if the transaction is cached during sync, its information can be invalid because the wallet is missing most of the required information.

What was done?

• Don't cache transactions if the wallet is syncing and the transaction is recent.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes
  • Improved caching behavior for transaction amounts to ensure more accurate and up-to-date values, especially during chain synchronization or for recent transactions.

[coderabbitai]

Walkthrough

The caching logic for the cachedDashAmount property in the dashAmount method was updated. Now, the amount is cached only if the blockchain is fully synchronized or if the transaction is older than 30 minutes, rather than being cached unconditionally.

Changes

File(s)	Change Summary
DashSync/shared/Models/Transactions/Base/DSTransaction.m	Modified caching logic for cachedDashAmount in dashAmount to depend on sync status and transaction age

Poem

In the warren of code where transactions hop,
Caching waits for sync, or for time to drop.
No more hasty storage for fresh little hares,
Only when old, or when sync clears the airs.
A smarter cache now, with patience and care! 🕰️🐇

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6a82ef and a93b104.

📒 Files selected for processing (1)

• DashSync/shared/Models/Transactions/Base/DSTransaction.m (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Mainnet Chain
• GitHub Check: Testnet E2E Tests
• GitHub Check: Objective-C Linter
• GitHub Check: Check Network
• GitHub Check: Testnet Chain

🔇 Additional comments (2)

DashSync/shared/Models/Transactions/Base/DSTransaction.m (2)

363-368: LGTM! Core logic correctly addresses the caching issue during sync.

The conditional caching logic properly prevents caching of recent transactions during wallet syncing, which aligns with the PR objective. The 30-minute threshold provides a reasonable buffer for sync completion.

---

365-365: ```shell
#!/bin/bash

Locate DSTransaction.m and display initializers and timestamp usage

FILE=$(fd --full-path DSTransaction.m | head -n1)
echo "DSTransaction file: $FILE"

Show initializer methods

rg -n '^[+-] (instancetype)init' -C3 "$FILE"

Show where timestamp is set or referenced

rg -n 'timestamp' -C5 "$FILE"

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

[pankcuf]

OK