Fix/masternode list pipelines

[pankcuf]

This pull request introduces a variety of changes across multiple files in the DashSync project, focusing on code simplification, bug fixes, and feature enhancements. The most significant updates include the addition of helper macros, improvements to threading for blockchain data operations, removal of unused or redundant code, and enhancements to error handling and configuration management.

Code Simplifications and Enhancements:

• Introduced a new macro FLAG_IS_SET in BigIntTypes.h to simplify bitwise flag checks.
• Replaced 1 << bits with 1U << bits in NSData+Dash.m to ensure proper unsigned integer operations. [1] [2]

Threading and Synchronization Improvements:

• Added asynchronous dispatch to the networkingQueue for blockchain data operations in DashSync.m, ensuring better thread management during chain sync restarts. [1] [2]

Code Cleanup:

• Removed unused macros and callback definitions in DSDashSharedCore.m, such as IssueWithMasternodeList, NotifySyncState, and get_cl_signature_by_block_hash. [1] [2]
• Simplified the initOnChain method by delegating diff configuration creation to a new method in DSChain+Checkpoint. [1] [2]

Error Handling Enhancements:

• Added a new method ffi_from_quorum_validation_error in NSError+Platform.h and updated its implementation to handle additional error cases. [1] [2] [3]

Configuration Management:

• Implemented a new method createDiffConfig in DSChain+Checkpoint for dynamic diff configuration creation based on the network type (mainnet or testnet). [1] [2]

These changes collectively improve the maintainability, performance, and robustness of the DashSync codebase.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This pull request simplifies code and enhances functionality in the DashSync project by improving checkpoint management, error handling, threading, and configuration.

• Introduces helper macros in BigIntTypes.h and improves bitwise ops in NSData+Dash.m
• Adds asynchronous dispatch for blockchain operations and refactors diff configuration creation
• Removes unused code and improves error handling in NSError+Platform.h

Files not reviewed (18)

• DashSync/shared/Categories/BigIntTypes.h: Language not supported
• DashSync/shared/Categories/NSData/NSData+Dash.m: Language not supported
• DashSync/shared/DSDashSharedCore.m: Language not supported
• DashSync/shared/DashSync.m: Language not supported
• DashSync/shared/Libraries/AdvancedOperations/Others/NSError+Platform.h: Language not supported
• DashSync/shared/Libraries/AdvancedOperations/Others/NSError+Platform.m: Language not supported
• DashSync/shared/Models/Chain/DSChain+Checkpoint.h: Language not supported
• DashSync/shared/Models/Chain/DSChain+Checkpoint.m: Language not supported
• DashSync/shared/Models/Chain/DSChain+Transaction.m: Language not supported
• DashSync/shared/Models/Chain/DSChain.m: Language not supported
• DashSync/shared/Models/CoinJoin/DSCoinJoinManager.h: Language not supported
• DashSync/shared/Models/CoinJoin/Utils/DSMasternodeGroup.m: Language not supported
• DashSync/shared/Models/Derivation Paths/DSDerivationPathFactory.m: Language not supported
• DashSync/shared/Models/Derivation Paths/DSFundsDerivationPath.m: Language not supported
• DashSync/shared/Models/Derivation Paths/DSGapLimit.h: Language not supported
• DashSync/shared/Models/Entities/DSBlockchainIdentityKeyPathEntity+CoreDataProperties.h: Language not supported
• DashSync/shared/Models/Identity/DSIdentity+ContactRequest.m: Language not supported
• DashSync/shared/Models/Identity/DSIdentity+Profile.m: Language not supported

Comments suppressed due to low confidence (1)

DashSync/shared/Models/Chain/DSChainCheckpoints.h:121

• [nitpick] Consider aligning the naming of the checkpoint path in the mainnet array with the other entries; using an uppercase prefix like 'ML' instead of 'mn_list_diff' could improve consistency.

{2227096, "000000000000000899fdcd85241296146c365b238a655517da8dcd08a8a79b98", 1740273743, 0x19287724u, "mn_list_diff_0_2227096", "298585a781111ad060e5e99669893a3999b52b1d8125be0297e7efc6e62ff231", "00000000000000000000000000000000000000000000a491879d910661346c7b"},

[Syn-McJ]

Looks good