backport: merge bitcoin#34227 (Fix osslsigncode tests)

[kwvg]

Additional Information

Required to fix Guix build failures on develop (7482956), see below

$ HOSTS=x86_64-w64-mingw32 guix-start
Checking that we can connect to the guix-daemon...
[...]
substitute: updating substitutes from 'https://berlin.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://bordeaux-singapore-mirror.cbaines.net'... 100.0%
substitute: updating substitutes from 'https://bordeaux-us-east-mirror.cbaines.net'... 100.0%
substitute: updating substitutes from 'https://hydra-guix-129.guix.gnu.org'... 100.0%
The following derivation will be built:
  /gnu/store/dwg4c8nvvylxx3y8l4rw6pmfz7b45mpr-osslsigncode-2.5.drv

building /gnu/store/dwg4c8nvvylxx3y8l4rw6pmfz7b45mpr-osslsigncode-2.5.drv...
\ 'check' phasenote: keeping build directory `/tmp/guix-build-osslsigncode-2.5.drv-2'
builder for `/gnu/store/dwg4c8nvvylxx3y8l4rw6pmfz7b45mpr-osslsigncode-2.5.drv' failed with exit code 1
build of /gnu/store/dwg4c8nvvylxx3y8l4rw6pmfz7b45mpr-osslsigncode-2.5.drv failed
View build log at '/var/log/guix/drvs/dw/g4c8nvvylxx3y8l4rw6pmfz7b45mpr-osslsigncode-2.5.drv.gz'.
guix shell: error: build of `/gnu/store/dwg4c8nvvylxx3y8l4rw6pmfz7b45mpr-osslsigncode-2.5.drv' failed

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[DashCoreAutoGuix]

Guix Automation has failed due to the HEAD commit not being signed by an authorized core-team member. Please rebase and sign or push a new empty signed commit to allow Guix build to happen.

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[DashCoreAutoGuix]

Guix Automation has began to build this PR tagged as v23.0.2-devpr7102.8f1cf15a. A new comment will be made when the image is pushed.

[DashCoreAutoGuix]

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.2-devpr7102.8f1cf15a. The image should be on dockerhub soon.

[kwvg]

Checksums for 8f1cf15

8ae3dd6037b6a7f5040bfe222b757b60b7e9876379a699001b6db6a8aa4fb1f9  dashcore-23.0.2-1052-g8f1cf15a58e1-aarch64-linux-gnu-debug.tar.gz
b42a577ee64d63c9a38419feaad8cb90e4b0a035659f60a0515a1fb618760601  dashcore-23.0.2-1052-g8f1cf15a58e1-aarch64-linux-gnu.tar.gz
7bbc625b583ea53ef7225ad25bfbe9c7798deaba389e39aae648b62d094dd572  dashcore-23.0.2-1052-g8f1cf15a58e1-arm64-apple-darwin-unsigned.tar.gz
35580f8edc05bc4b5b2dda86b79a79dc31141b741f5842f91897c1c7ed5f6624  dashcore-23.0.2-1052-g8f1cf15a58e1-arm64-apple-darwin-unsigned.zip
f3743f39bdb73fc50a89fd5d0757e8f87fac6284dc5213b903e65d18d2d7684b  dashcore-23.0.2-1052-g8f1cf15a58e1-arm64-apple-darwin.tar.gz
943e9749575a29393d45e09c2e8ece10ac3c1c9110e0d072bce4e6f33ad9e0e3  dashcore-23.0.2-1052-g8f1cf15a58e1.tar.gz
1b9a4e822d1baa59637101641eed7618a63ce6213c3e6bf146e1d6300b5f29cd  dashcore-23.0.2-1052-g8f1cf15a58e1-riscv64-linux-gnu-debug.tar.gz
1f8b304b4686a00e2cb963395be12f41f199e4934b15e085b013bcf70340b087  dashcore-23.0.2-1052-g8f1cf15a58e1-riscv64-linux-gnu.tar.gz
0b6d8248615cca5bacab03aeb42d4b531c04ef42a875bf91de6f1907ec9aeee8  dashcore-23.0.2-1052-g8f1cf15a58e1-x86_64-apple-darwin-unsigned.tar.gz
942e5f8ccb160bff2fe83bcf4faf85519705cee6d0119fa400ebbfcb831c2a5a  dashcore-23.0.2-1052-g8f1cf15a58e1-x86_64-apple-darwin-unsigned.zip
9fefedf908ceb1bddaebd5eabbd7e1d0960fa4df336fede94835f9fa350aaffb  dashcore-23.0.2-1052-g8f1cf15a58e1-x86_64-apple-darwin.tar.gz
bbd95b84a14530f3ccc5d470b8cbc7f9054bc4156fbd11d20292e39df5870a07  dashcore-23.0.2-1052-g8f1cf15a58e1-x86_64-linux-gnu-debug.tar.gz
680b116d101bdcd1fdf4b6f0c4aee811a726ab5150230ae99edcfb4f619ed705  dashcore-23.0.2-1052-g8f1cf15a58e1-x86_64-linux-gnu.tar.gz
194d662af33e0ebe6fe8cc9b650f82031de6d97f61bb6eb1202fe486caa18795  dashcore-23.0.2-1052-g8f1cf15a58e1-win64-debug.zip
a1945f5337d84dcfb264105f343baed297f88383270713113f418b59d93bebee  dashcore-23.0.2-1052-g8f1cf15a58e1-win64-setup-unsigned.exe
61d39a859483e156a24dac85d3e5c4b68bbc18dea17b31e81743b30038cd8d90  dashcore-23.0.2-1052-g8f1cf15a58e1-win64-unsigned.tar.gz
3c9ee1f93a8cffbd1631bbebf93f2605e735e7d330e5020acb9ecb0c7eaabb20  dashcore-23.0.2-1052-g8f1cf15a58e1-win64.zip

[coderabbitai]

Walkthrough

The osslsigncode package in the Guix manifest was updated to address test failures after 2025. The libfaketime dependency was added to the package inputs, and the check phase was modified to wrap test invocations with faketime, simulating an earlier date during test execution. This conditional modification allows tests to pass without changes to the test suite itself, while permitting the system clock to advance beyond 2025.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: backporting Bitcoin PR #34227 to fix osslsigncode tests, which directly addresses the Guix build failures mentioned in the PR description.
Description check	✅ Passed	The description is related to the changeset, explaining the motivation (fixing Guix build failures), providing error context, noting no breaking changes, and including a completed checklist.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7482956 and 8f1cf15.

📒 Files selected for processing (1)

• contrib/guix/manifest.scm

🧰 Additional context used

📓 Path-based instructions (1)

{guix-build*,releases,**/guix-build*,releases/**,.github/**,depends/**,ci/**,contrib/**,doc/**}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not make changes to build system files (guix-build*), release artifacts, or avoid changes to .github, depends, ci, contrib, and doc directories unless specifically prompted

Files:

• contrib/guix/manifest.scm

🧠 Learnings (1)

📓 Common learnings

Learnt from: knst
Repo: dashpay/dash PR: 6916
File: src/univalue/include/univalue.h:81-88
Timestamp: 2025-10-25T07:08:51.918Z
Learning: For backport PRs from bitcoin/bitcoin, bitcoin-core/gui, etc., backported changes should match the original upstream PRs even if they appear strange, modify vendored code, or seem to violate coding guidelines. Still flag genuine issues like bugs, undefined behavior, crashes, compilation errors, or linter failures.

Learnt from: knst
Repo: dashpay/dash PR: 6871
File: contrib/guix/libexec/build.sh:358-360
Timestamp: 2025-10-05T20:38:28.457Z
Learning: In the Dash repository, when backporting code from Bitcoin Core, typos and minor issues in comments should be kept as-is to reduce merge conflicts in future backports, even if they remain unfixed in Bitcoin Core's master branch.

Learnt from: kwvg
Repo: dashpay/dash PR: 6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request `#6543` is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.

Learnt from: knst
Repo: dashpay/dash PR: 6883
File: src/rpc/rawtransaction.cpp:1088-1125
Timestamp: 2025-10-13T12:37:12.357Z
Learning: In backport pull requests (especially from Bitcoin Core), treat "moved" or refactored code as out-of-scope for content-level review. Focus validation on verifying that code is moved correctly: no fields added, no fields removed, no fields reordered, and no unexpected changes beyond whitespace adjustments. Pre-existing issues in the upstream code should be preserved to maintain fidelity to the original implementation.

Learnt from: PastaPastaPasta
Repo: dashpay/dash PR: 6804
File: src/qt/proposalwizard.cpp:40-42
Timestamp: 2025-08-11T17:16:36.654Z
Learning: In the Dash repository, when a PR adds new files that are not from Bitcoin backports, these files must be added to the list in test/util/data/non-backported.txt. This applies to newly created files like qt/proposalwizard.{h,cpp} and forms/proposalwizard.ui. Limited exemptions may exist for subtrees and similar cases.

Learnt from: kwvg
Repo: dashpay/dash PR: 6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (`#6718`), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

Learnt from: kwvg
Repo: dashpay/dash PR: 6761
File: src/chainlock/signing.cpp:247-250
Timestamp: 2025-07-29T14:32:48.369Z
Learning: In PR `#6761`, kwvg acknowledged a null pointer check issue in ChainLockSigner::Cleanup() method but deferred it to follow-up, consistent with the pattern of avoiding scope creep in refactoring PRs.

🔇 Additional comments (2)

contrib/guix/manifest.scm (2)

6-6: LGTM!

The selective import for libfaketime follows the existing pattern and is properly placed among the other imports.

---

214-224: LGTM! Correctly implements the upstream fix for date-sensitive test failures.

The implementation properly:

• Replaces the check phase to wrap test execution with faketime
• Handles the tests? flag conditionally
• Adds libfaketime as a dependency

Based on learnings, this matches the upstream bitcoin#34227 backport and should be kept as-is.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[knst]

utACK 8f1cf15