fix(desktop): BrowserWindow 破棄後の IPC 送信で「Object has been destroyed」クラッシュを修正 - #128
Merged
Conversation
シャットダウン中にタイマーが発火して notifySessions → onSessionsChange が呼ばれると、 すでに破棄された BrowserWindow の webContents に send しようとしてクラッシュしていた。 sendToRenderer ヘルパーで isDestroyed() チェックを挟むことで回避する。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BrowserWindow が破棄された後も win 変数が null にリセットされないことが Object has been destroyed クラッシュの根本原因だった。 closed イベント（close を preventDefault しない場合のみ発火）で win = null を セットすることで、sendToRenderer の isDestroyed() チェックと合わせた二重ガードにする。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifySessionsが呼ばれると、すでに破棄されたBrowserWindowのwebContentsに IPC 送信してクラッシュしていた問題を修正sendToRendererヘルパーを追加し、isDestroyed()チェックを通過した場合のみ送信するように変更Closes #127
Test plan
🤖 Generated with Claude Code