fix(mobile): PermissionSheet の表示安定性を改善 - #119
Open
dashi296 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
キーボード表示時に
PermissionSheetが正しく位置調整されなかった問題を修正。問題の原因
PermissionSheet自身がposition: absoluteとbottom: keyboardHeightを保持していたため、SafeAreaViewの座標系と食い違いが生じ、キーボード表示中にシートの位置がずれる・隠れるケースがあった。変更内容
PermissionSheet.tsxposition: absolute / left: 0 / right: 0 / bottom: 0を除去し、純粋なコンテンツコンポーネントに変更useKeyboardHeight依存を除去sheetPaddingBottomの計算をキーボード表示有無の分岐から24 + bottomInset固定に統一zIndex: 10を除去TerminalScreen.tsxpermissionOverlayラッパーViewを追加し、position: absoluteとbottom: keyboardHeightをここで一元管理pointerEvents="box-none"を設定し、背後の WebView / KeyboardToolbar へのタッチを妨げないようにzIndex: 10に WebView / toolbar スタックの上に表示するための意図をコメントで明示TerminalScreen.test.tsxuseKeyboardHeightのモック追加PermissionSheetが表示されることを確認するテストを追加permissionOverlayのbottomスタイル値がkeyboardHeightと一致することをアサートcreatedAtフィールドを補完テスト
全 125 テスト PASS
🤖 Generated with Claude Code