Repository navigation
fix: unlock the node when eq panics in CompareAndDelete - #13
Merged
Merged
Conversation
CompareAndDelete called eq with the key's trie node locked and unlocked it only on the normal return paths, so a panicking eq - or == on a ComparableMap[K, any] value whose dynamic type is not comparable, such as []byte - left the node locked once the caller recovered, and every later write to that subtree blocked forever. The unlock is now deferred unless pruneEmpty takes the lock over. CompareAndSwap and LoadOrCompute already defer the unlock; a regression test now covers all three. The doc comments now say where eq runs: CompareAndSwap calls it once without the lock to find the entry and again with it, so in both methods it must not use the map. Deviation from upstream internal/sync.HashTrieMap: upstream CompareAndDelete unlocks explicitly on each path, as this code did. It only compares values with the runtime's type equality, so the same hazard exists there for sync.Map values of a non-comparable dynamic type; here eq is arbitrary user code, so the unlock is deferred. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found in a one-off review of competitor issues over their whole history; each bug is reproduced by a regression test that failed before the fix.
Changes
Notes
Testing
go vet,golangci-lint runandgo test -race ./...pass locally.