Repository navigation
docs: document read and write operations as sync.Map does - #12
Merged
Merged
Conversation
Map promises the concurrency guarantees of sync.Map but never spelled out which calls are read and which are write operations. Add the paragraph with the wording from Go commit ede4e4f (golang/go#81187): Delete and LoadAndDelete are writes only when they delete an entry. A test holds the root lock and checks that deleting a missing key returns without taking it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mappromises the concurrency guarantees ofsync.Mapbut never spelled out which calls are read and which are write operations. This adds the paragraph to theMapdoc with the wording from Go commit ede4e4f (golang/go#81187):DeleteandLoadAndDeleteare write operations only when they delete an entry.A new internal test holds the root lock and checks that
Delete,LoadAndDeleteandCompareAndDeleteof a missing key return without taking it.