Repository navigation
refactor: no dead nil checks for pointer values of a map - #12
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
darxnet
force-pushed
the
refactor/fresh-map-values
branch
from
November 16, 2026 11:04
9cecba6 to
c6685a5
Compare
A map value is copied into a fresh zero variable, so for a pointer to a
struct with CopyFrom the generated `w = nil` and `if w == nil` could never
matter. copyCode takes fresh and emits only `if v != nil { w = new(T);
w.CopyFrom(v) }` there; arrays pass it down, slice elements do not.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
darxnet
force-pushed
the
refactor/fresh-map-values
branch
from
November 16, 2026 11:10
c6685a5 to
255b651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A map value is copied into a fresh zero variable, so for a pointer to a
struct with CopyFrom the generated
w = nilandif w == nilcould nevermatter. copyCode takes fresh and emits only
if v != nil { w = new(T); w.CopyFrom(v) }there; arrays pass it down, slice elements do not.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com