Repository navigation
Chart SYSTEM1/2.RC0 in the atlas: a 716-byte pair, not an empty file - #150
Merged
Merged
Conversation
The atlas said the pedal's settings files were zero bytes and uncharted. On a working card both carry a <sys> document with SETUP, MIDI and CTL, and the same pair-and-counter mechanism as MEMORY1/2 — which the core has read by since SystemFile.hpp. Replace the paragraph with one section in the atlas's own shape: the pair and which file wins, a table per section with the observed values, and the confidence each fact earned. MemoryNumber is the pedal's selected memory, zero-based, and the pedal rewrites the pair when that changes; the CTL names follow the manual's lists as Controls.hpp decodes them; the SETUP and MIDI meanings stay unknown until read off the screen.
…overed Testers keep asking whether the pedal can save a memory by itself. The settings file is now charted, and nothing in its three sections names a save, a write-on-change or a confirmation. Write that down next to the tables; whether the pedal behaves that way with no stored setting behind it is still a question for the manual or the hardware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148.
docs/pedal-settings.mdclaimedSYSTEM1/2.RC0were zero bytes and uncharted. On a working card both files are 716 bytes and carry the same pair-and-counter mechanism as MEMORY1/2; the code has known this sinceSystemFile.hppandControls.hpplanded, the atlas had not caught up.SYSTEMsection in the atlas's own shape: the pair rule (which file wins), the observation that switching the current memory is a SYSTEM write, and one table per section (SETUP, MIDI, CTL) with the file's confidence marks. Field names, presence,MemoryNumber's meaning and zero base are [V]; CTL names are [M] from the listsControls.hppalready cites (reference manual pp. 13-14); SETUP and MIDI meanings beyond the tag names are [?] until read off the screen.Docs only; no code changes.