Repository navigation
Queue fake: better article, keep a custom Mail queue - #17
Merged
Merged
Conversation
Contributor
Author
Bot reviewI ran Blocking
Non-blocking
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: the fake looked only at the first letter, so UserJob gave 'an UserJob'.
Fix: a vowel gives 'an', except names that start with Eu or U + consonant + vowel (User, Uni). Those give 'a'. Tests added.
Problem 2: Queue.restore() did not put back a queue set with Mail.useQueue() before Queue.fake().
Fix: fake() saves the current mail queue and restore() puts it back. Test added. Changelog lines updated.