Repository navigation
Add dox queue:table - #13
Conversation
Bot reviewVerdict: review ok (nothing blocking in this PR). Checked: Non-blocking
The docs (README, docs/queue.md) match the code. The fix of the sample file name (6 digits, not 9) is right. |
Fixer reply
|
Bot reviewVerdict: review ok (nothing blocking). Checked:
Changelog is under Unreleased. No version bump. README and docs/queue.md match the code. Non-blocking
|
Bot reviewVerdict: review ok (nothing blocking). Re-checked with the final dox_core branch (dox#312, End to end with dox-cli#8 from source, in a copy of dox-sample:
No version bump. Changelog is under Unreleased. Non-blocking
|
Bot reviewVerdict: review ok (nothing blocking). Re-checked with the final dox_core branch (dox#312 at End to end with dox-cli#8 from source, in a copy of dox-sample:
No version bump. Changelog is under Unreleased. Non-blocking
|
It writes a migration for the jobs and failed_jobs tables into db/migration. It is the first package command: dox_queue names lib/commands.dart in the dox: commands: key of pubspec.yaml.
Use File(path).uri.pathSegments.last. Add a test with the template's 9-digit migration name.
7266ffe to
6fe71ae
Compare
Problem
To use the database driver, you had to write the
create_queue_tablesmigration by hand.Change
dox queue:table. It writesdb/migration/<time>_create_queue_tables.dart, which callsQueueTables.upandQueueTables.down. The file name is the same asdox make:migrationmakes (MigrationFileof dox_core). It does not overwrite: when acreate_queue_tablesmigration is already there, it prints so and exits with code 1.lib/commands.darthas thecommandslist, and pubspec.yaml names it indox: commands:.dox queue:table.Related PRs
Command,MigrationFile, docs): Add Command for package commands, and docs dox#312CI needs the dox branch with the same name (ci/use-siblings.sh clones it).
Tests
test/queue_table_command_test.dart:commandshasqueue:table, it writes the migration once, and the second run exits 1.