Repository navigation
Fix a missed close, and test before every release - #7
Merged
Merged
Conversation
…lose came together CI: the tests also run on a release tag, and the build waits for them. A red test now stops the release and the publish.
This was referenced Nov 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when the server ends a connection, the error and the close can arrive in one read. The driver read the error but did not read once more, so it never saw the close. The query on that connection waited for the 300 s timeout. CI on main caught it (pipeline_test: a connection the server ends).
Fix: when the poll event says the server closed or the socket failed, read on to the end of the stream.
CI: the tests now also run on a release tag, and the build waits for them. Before, the tag run skipped the tests, so 3.0.1 was published while main was red.