Repository navigation
Count DO as a schema change, and do not retry a stale statement inside a transaction - #11
Merged
Merged
Conversation
Contributor
Author
Bot reviewBlocking: none. Non-blocking:
Checked:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale prepared statements after a schema change (follow-up to #10).
DO. ADOblock did not count as a schema change. So a table rebuilt in aDOblock kept the old param types ('007'stored as'7'). Now theDOCommandComplete tag counts too.DOis mostly used for migrations, so this does not touch the hot path. New test (fails on main).No native ABI change. No version bump. CHANGELOG under Unreleased.
Checks: cargo fmt / clippy / test (12 passed), dart format / analyze, Dart tests on Postgres 16 (43 passed).
Measure at release: the query path (
/db,/queries).is_ddlhas one more compare per CommandComplete. Expected: no change.