Repository navigation
test: logger and printers, fix nested transaction comment - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behaviour change. Only tests and comments.
QueryBuilder.transactionsaid a nested call joins the outer transaction. That is wrong. A nested call makes a savepoint, and a failure inside rolls back to that savepoint. The comment now says this.Loggerand the three printers hadcoverage:ignore-file. Some tests already existed from fix: ORM log safety, @name in strings, TLS warning #24 (value order,logRedact,FileQueryPrintersync and buffered,Logger.warn). I added only what was missing:ConsoleQueryPrinter: json line, andfilterFileQueryPrinter:filter, and a failed buffered write does not throwPrettyQueryPrinter: query and params outputLogger.info,success,dangercolourscoverage:ignore-filefrom all four files. Every branch in them is now run by a test.Checked:
dart format,dart analyze --fatal-infos packages, SQLite tests pass.