Repository navigation
Write a deleted command runner again, new queue commands, tighter doc test - #14
Merged
Merged
Conversation
…nt test Another dox can delete .dart_tool/dox/commands.dart between the check and the read. This run crashed then. Now a missing runner is written again from the cache. The stub doc comment test now flags only a tag like <String>, not any '<' like 'a < b'.
They run bin/queue.dart clear, restart and prune-failed from dox_queue. The queue:work help now also lists --backoff, --max-jobs, --max-time and --memory.
Contributor
Author
Bot reviewBlocking: none. Non-blocking:
Checked:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doxcan delete.dart_tool/dox/commands.dartbetween the exists check and the read. This run crashed then. Done: the cache path no longer checks first. It reads the file, and when the read fails it writes the file again from the cache. Test added (runner deleted, cache kept).<, evena < b. Done: it now flags only a tag like<String>or</p>.--step 2(with a space): already works on main, with a test (confirm_drop_test.dart). Nothing to do.--batch N: skipped.Migrator.rollbackin dox_migration (dox-orm repo) has no batch option, andbin/migrate.dartdoes not read--batch. That must land in dox-orm first. Then the CLI only needs to pass--batchon, like--step.Tests: dart format, dart analyze --fatal-infos, dart test (143 passed).
queue:clear [queue],queue:restartandqueue:prune-failed [--hours=N]. They runbin/queue.dart clear|restart|prune-failed, like the otherqueue:*commands. Thequeue:workhelp now lists--backoff,--max-jobs,--max-timeand--memory(passed on as is). Test cases added. These commands need dox_queue with Job options, worker limits, queue commands, fake fixes dox-queue#18 to run; with an older dox_queue,bin/queue.dartdoes not know them.