Repository navigation
Fix exit codes, make:model table and fillable, serve port warning, rollback production check - #10
Merged
Merged
Conversation
Contributor
Author
Bot reviewVerdict: OK to merge. I found nothing blocking. What I checked:
Small notes (not blocking):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small CLI fixes. One commit per fix.
Exit code
doxexited with 0 when there was no command, the command was unknown, the arguments were wrong, or the command threw. Scripts and CI could not see the failure.make:model
make:model Postwrote@DoxModel(), so the ORM used the tablepost. But-mmakes the tableposts.@DoxModel(table: 'posts').fillablelist with a comment. A model is guarded, socreate(req.body)throwsMassAssignmentExceptionuntil the user lists the columns. The comment says this.dox serve --port
dox serve --port=8080ignored the flag with no message.APP_PORTin.env, or to runAPP_PORT=8080 dox serve. The server still starts.Production check
migration:rollbacknow has the same production check asfresh,resetandrefresh. It takes--forcetoo.dox migrate --forcestill works with no error.--forceis not passed on tobin/migrate.dart.--forceis not passed on.Checks:
dart analyzehas no issues.dart testpasses (127 tests).