You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a suitePath getter which gives the package relative path to the current suite if it is available.
Only works in the test runner itself (we could maybe support some other scenarios if we wanted, using Platform.script on the VM and Uri.base on the web).
On the web, Uri.base already actually contains the full path including the suite, so you don't want to use this there which is a bit weird. On the VM you want to do something like Uri.base.resolve(suitePath).resolve(<some-suite-relative-path>).
We could consider instead providing a function for resolving suite relative paths, or make this API give you the absolute path to the suite (which would be an http URI on the web).
We could also add a <base> tag to the html page, setting it to be the package root.
I also expanded the test coverage in test_api to VM/chrome and all compilers, just to ensure this works everywhere.
This is only meant to solve the original problem stated in #110, which is getting the path to the test script. It does not help with getting access to the package root, but Uri.base does already give you that (whenever using the test runner).
Does this get impacted by changes to the working directory?
Probably, although I don't know for sure. But, that is partially why I like just exposing the relative suite path. We can be out of the business of the rest of it, which isn't really in our control. We can provide suggestions with caveats (like using Uri.base), which will work for most, but we don't guarantee them or support them directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible resolution to #110.
Adds a
suitePathgetter which gives the package relative path to the current suite if it is available.Uri.basealready actually contains the full path including the suite, so you don't want to use this there which is a bit weird. On the VM you want to do something likeUri.base.resolve(suitePath).resolve(<some-suite-relative-path>).<base>tag to the html page, setting it to be the package root.I also expanded the test coverage in
test_apito VM/chrome and all compilers, just to ensure this works everywhere.