JAST USA Library: Handle updated product response - #766
Open
Dawnflare wants to merge 1 commit into
Open
Conversation
Dawnflare
marked this pull request as ready for review
July 26, 2026 05:24
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the JAST failed sync issue described in #765
Details
variantsfield and deserializegamefrom the containing productvariantplus product-levelgamedatavariant.gameRoot cause
JAST changed the authenticated library response around July 23, 2026. The plural
products[].variantsfield now contains JSON-LD URI references such as/api/v2/shop/product-variants/nnya033instead of embedded variant objects. The existing DTO declared this field asVariant[], so Newtonsoft.Json aborted with aJsonSerializationExceptionbefore the library could be imported.The same response update also moved
gamefrom the singular embeddedvariantto its containing product. Ignoring only the plural field would therefore deserialize successfully but later fail when mapping the game and translation data.User impact
JAST USA library synchronization currently fails for affected users on every attempt. This change accepts the updated response shape and restores game import while remaining compatible with the earlier nested-game shape.
Validation
JastUsaLibrary.csprojsuccessfully with MSBuild in Debug configurationgamethrough the fallback pathgit diff --checkFixes #765