Skip to content

FCR: incorporate fixes and spec ceil expression#98

Merged
dapplion merged 2 commits into
fcrfrom
lh-codex-fcr-ceil-spec
Jul 1, 2026
Merged

FCR: incorporate fixes and spec ceil expression#98
dapplion merged 2 commits into
fcrfrom
lh-codex-fcr-ceil-spec

Conversation

@dapplion

@dapplion dapplion commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • incorporate the changes from dapplion/lighthouse:fcr-fixes
  • keep the PR FCR: align committee weight estimate with spec #96 spec-shaped committee-weight estimate structure
  • replace div_ceil(1000) with the spec-shaped (estimate + 999) // 1000 arithmetic using checked ops
  • handle missing checkpoint lookups without a dummy checkpoint sentinel
  • make get_equivocation_score iterate the equivocating set directly

Tests

  • cargo check -p fast_confirmation
  • pre-push make lint hook

Earlier on this branch before the latest cleanup:

  • cargo test -p fast_confirmation
  • cargo test -p ef_tests --features ef_tests fast_confirmation

@dapplion dapplion changed the title FCR: use spec ceil expression for committee estimate FCR: incorporate fixes and spec ceil expression Jul 1, 2026
@dapplion dapplion force-pushed the lh-codex-fcr-ceil-spec branch from a601e92 to ed1e4c5 Compare July 1, 2026 22:37
@dapplion dapplion force-pushed the lh-codex-fcr-ceil-spec branch from ed1e4c5 to 2a0d319 Compare July 1, 2026 22:40
@dapplion dapplion merged commit 339f000 into fcr Jul 1, 2026
7 checks passed
@dapplion dapplion deleted the lh-codex-fcr-ceil-spec branch July 1, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant