Repository navigation
keep the hero scroll cue below the resume button - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scroll cue was pinned 2rem from the bottom of the hero, so whenever the hero ran taller than the screen (large text, small phones, short desktop windows) it covered the Download Resume button. It now sits in the flow under the actions; the terminal stays centred in the remaining space.
Overlap before/after: 390px at 1.5x and 2x text, 360x640, 1440x700 all overlapped; none do now. Normal 390 and 1440x900 keep the cue at the bottom of the hero.