Repository navigation
feat(talos): move machine configs to the v1.14 config contract - #4947
Merged
Merged
Conversation
Set configContract to v1.14 and convert the patches to Talos 1.14 configuration documents. Node behaviour is unchanged: every default the v1.14 base introduces is pinned to what the nodes ran under v1.13. - patches and node files become KubeAPIServerConfig, KubeletConfig, KubeNodeConfig, ResolverConfig, SysctlConfig, TimeSyncConfig, UnattendedInstallConfig and friends; etcd, machine.certSANs and the containerd customization stay v1alpha1 - OIDC moves from machine.files + extraVolumes to KubeAuthenticationConfig, with anonymous access kept off and the apiserver probes kept off - 70-pinned-defaults.yaml removes workload isolation, the secure EPHEMERAL mount and the weekly trim that the v1.14 base would turn on - render.sh keeps the identity fallback provider in the etcd encryption config and no longer injects the service-account key (the base has it) - the doubled os:admin Talos API role is deduplicated
A machine config diff contains CA keys and tokens, which made talos:diff-node, diff-cluster and apply-node unsafe in logs and agent sessions. diff.sh runs the dry run and prints only the apply mode, line counts and the keys and documents that change. FULL=true shows the raw diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the talhelper replacement (#4939):
configContractgoes fromv1.13tov1.14and the patches become Talos 1.14 configuration documents. This is already live on all 11 nodes (applied 2026-11-21, no reboots); merging makesmainmatch the cluster again.The aim was no change in what the nodes do. A v1.14 base changes defaults as well as layout, so each one is pinned to what the cluster ran before.
Commits
KubeAPIServerConfig,KubeAdmissionControlConfig,KubeAuthenticationConfig,KubeControllerManagerConfig,KubeSchedulerConfig,KubeletConfig,KubeNodeConfig,KubeNetworkConfig,ResolverConfig,SysctlConfig,TimeSyncConfig,KernelModuleConfig,KubeTalosAPIAccessConfigandUnattendedInstallConfig. etcd settings andmachine.certSANshave no document yet and stay v1alpha1.machine.files+extraVolumes+--authentication-configtoKubeAuthenticationConfig. Same two JWT authenticators; anonymous access stays off.patches/global/70-pinned-defaults.yamlremoves what a v1.14 base would turn on: workload isolation, the secure/varmount and the weekly filesystem trim. kube-proxy, CoreDNS and Flannel stay off.startupProbes: falseon the apiserver, as before. The probes are anonymous requests, so they must stay off while anonymous access is off.render.shappends theidentityprovider toKubeEtcdEncryptionConfig. Talos generated secretbox + identity before 1.14; the v1.14 base has secretbox only.render.shno longer injects the service-account key (the base carries it), and the doubledos:adminTalos API role is deduplicated.talos:diff-node,diff-clusterandapply-nodenow print a summary (apply mode, line counts, changed keys and documents) instead of the raw diff, which contains CA keys and tokens.FULL=trueshows the raw diff.Not converted
patches/global/20-machine-files.yaml(containerddiscard_unpacked_layers) is stillmachine.files, so Talos prints one deprecation warning. TheCRICustomizationConfigreplacement changes the merged containerd config header, which restarts containerd on every node. Planned for the next Talos upgrade.Verified
--mode=no-reboot: one worker, then the three control planes, then the other workers. Runtime resources were snapshotted before and after each apply.legacy→default). kubelet and containerd did not restart./livezand/versionreturn 401, Secrets read back, a freshly minted service-account token is accepted, the rendered auth config hasanonymous.enabled: falseand both issuers, authorizers are Node and RBAC, the encryption config is secretbox then identity, and the pod has no probes.task talos:diff-cluster: 11/11no changes. 11/11 nodes Ready, all Flux Kustomizations and HelmReleases ready..private/backups/2026-11-21-pre-config-contract-v1.14/and Infisical/Infrastructure/Talos/Backups(TALOS_BACKUP_20261121_PREV114_*).