refactor(console): de-mock HITL/Ordens/Usuários + migra specs (limpeza de mocks 5.4) - #108
Merged
Merged
Conversation
…a de mocks 5.4) Quinta fatia (strangler). Remove as branches de mock de PRODUÇÃO de 3 telas e migra rbac.spec + pair_dimension.spec para o fixture. Coexistência mantida (o core sai na 5.7). Diff 100% em docs/design/pages/. Telas de-mockadas: - screen_hitl, screen_orders, screen_users (removido const mock / if(mock) / blocos de mock-data CT.*). Vazamento latente religado (só o HITL): <ConfidenceBreakdown breakdown= CT.confidenceBreakdown> no render real → order.confidence_breakdown (por ordem, vindo de /v1/orders — coerente com o Fix #3 que pôs a confiança no payload). Ordens/Usuários sem vazamento (o myEmail de Users é auth, preservado). Gating de demo PRESERVADO (separado do mock): no HITL, canApprove/demoView/ demoAutonomy + aviso "Somente leitura…" + botões disabled com data-tip ficam intactos — só os short-circuits if(mock) saíram. (rbac test 2 afirma esses tooltips.) Fixture (e2e/fixtures/): - HITL_CONFIG enriquecido ao shape completo (current_level, human_approved/rejected_ today, levels[]). ORDERS (pendentes, BTC+ETH, confidence + confidence_breakdown), TRADES (fechados, ≥2 símbolos), USERS (exatamente 3 — rbac test 3), ROLES (com permissions p/ a matriz). /v1/orders no baseline passa de [] para ORDERS. Specs migrados: rbac.spec (cenários via installMockApi authMode/role, não mais MOCK_ROLE/MOCK_AUTH), pair_dimension.spec. Acoplamento corrigido (mesmo padrão da 5.3b): system.spec "admin reaches the users screen" navega #users e afirma o page-title → Users de-mockada precisa do fixture; instalado NESSE teste (serve /v1/users+/v1/roles; USE_MOCK_DATA segue p/ a auth mock). 403/404 do system são route-guard (intactos); console afirma só labels de nav. Auditoria de mocks: 3 telas sem USE_MOCK_DATA/CT.* (grep limpo). Restam: core+shell+ landing (5.7), Agentes (5.6), grupos 5.5–5.6. Validação: 11 specs migrados verdes (rbac 4 + pair_dimension 3 + system 4); suíte completa 75 verdes (retries=1); node build.mjs OK. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZ3vLNTHKekjQVtjFVRi5D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limpeza de mocks — Fatia 5.4 (HITL · Ordens · Usuários)
Remove as branches de mock de produção de 3 telas e migra
rbac.spec+pair_dimension.specpara o fixture. Coexistência mantida (core sai na 5.7). Diff 100% emdocs/design/pages/, zero backend.Telas de-mockadas
screen_hitl·screen_orders·screen_users— removidoconst mock/if (mock)/ blocos de mock-dataCT.*.Vazamento latente religado (só o HITL)
<ConfidenceBreakdown breakdown={CT.confidenceBreakdown}>no render real →order.confidence_breakdown(por ordem, de/v1/orders) — coerente com o Fix #3, que pôs a confiança no payload da ordem. Ordens/Usuários sem vazamento (omyEmailde Users é auth, preservado).Gating de demo PRESERVADO (separado do mock)
No HITL,
canApprove/demoView/demoAutonomy+ o aviso "Somente leitura…" + botõesdisabledcomdata-tipficam intactos — só os short-circuitsif(mock)saíram. (rbac test 2 afirma exatamente esses tooltips → aceite verificado.)Fixture (
e2e/fixtures/)HITL_CONFIGenriquecido ao shape completo (current_level,human_approved/rejected_today,levels[]).ORDERS(pendentes, BTC+ETH,confidence+confidence_breakdown),TRADES(fechados, ≥2 símbolos),USERS(exatamente 3 — rbac test 3),ROLES(compermissionsp/ a matriz). Baseline/v1/orderspassa de[]paraORDERS.Acoplamento corrigido (mesmo padrão da 5.3b)
system.spec"admin reaches the users screen" navega#userse afirma o page-title → Users de-mockada precisa do fixture; instalado nesse teste (serve/v1/users+/v1/roles;USE_MOCK_DATAsegue p/ a auth mock). 403/404 dosystemsão route-guard (intactos);consoleafirma só labels de nav.Auditoria de mocks
3 telas sem
USE_MOCK_DATA/CT.*(grep limpo). Restam: core+shell+landing (5.7), Agentes (5.6), grupos 5.5–5.6.Validação local
--retries=1).node build.mjsOK.🤖 Generated with Claude Code
Generated by Claude Code