Repository navigation
fix(test): 偽 ffmpeg のエンコードの時刻を EPOCHREALTIME から作る - #2796
Merged
Merged
Conversation
Ubuntu 26.04 の date (uutils coreutils 0.10.0) は `%3N` で秒の端数の先頭の 0 を落としてから 3 桁を出す。 毎秒の最初の 0.1 秒に残した時刻が最大 0.9 秒ずれ、CI で 2 本のエンコードが重ならないように見えた。 テストは残った時刻が起動から終了までの間に入ることも確かめ、落ちたら時刻をそのまま出す。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8TqVbtN2Hp8wNmqBX8pzT
|
Claude finished @5ym's task in 16s —— View job レビュー結果問題無しです。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/lib/server/fake-ffmpeg.test.tsの「2 本の間は重なる」が CI でたまに落ちていた (job 132382838467)。待つ処理は動いていて、残した時刻のほうがずれていた。dateは uutils coreutils 0.10.0。date +%s%3Nは秒の端数の先頭の 0 を落としてから 3 桁を出す (ubuntu:26.04で 60 回試して 6 回、最大 0.89 秒ずれた)。落ちた回の 2 本目の始まり…240.995は、ログの時刻から見ると実際は…240.09xで、この形のずれに合うEPOCHREALTIMEから時刻を作る。同じ条件で 60 回試してずれは 0 回e2e の
03-recording-chaptersが比べる時刻も同じファイルから来るので、同じずれが無くなる。🤖 Generated with Claude Code
https://claude.ai/code/session_01T8TqVbtN2Hp8wNmqBX8pzT