fix: align --help output with actual flag parser (#6)#86
Merged
mattleaverton merged 1 commit intoApr 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From
docs/plans/2026-04-24-kilroy-fixes-from-feedback.mditem #6.Bug:
kilroy attractor run --helpdid not document--tmux,--prompt-file,--label,--workspace,--input,--package,--detach, or--skip-preflight.kilroy attractor runs --helplisted onlylistandprune— noshow, nowait. Every flag the shipped skills depend on was undiscoverable.Fix:
cmd/kilroy/main.go(top-levelusage()) andcmd/kilroy/attractor_runs.go(runsUsage()) to list every flag the parser accepts.TestHelpUsageDrift— static-scan drift test that reads the source, extractscase "--foo":arms, extracts flags fromfmt.Fprintlnusage lines, and asserts every parser flag appears in the usage text. This is the durable fix — the same drift will happen again otherwise.Named constants (like
skipCLIHeadlessWarningFlag) are automatically excluded by the string-literal check, so no allowlist needed.Flags newly documented
attractor run:--tmux,--package,--input,--prompt-file,--workspace,--label,--skip-preflight.attractor runs prune:--older-than.attractor runs:showandwaitsubcommands added to top-level usage.Test plan
TestHelpUsageDriftwith 5 subtests — all pass.go test ./cmd/kilroy/...passes.Risks / follow-ups
attractorRun,attractorRunsList/Show/Wait/Prune. Other parsers (attractorResume,attractorStatus,attractorStop) follow the same pattern — onet.Runper function. Worth extending.Context
Produced by a dogfood quick-launch run against this repo.
🤖 Generated with Claude Code